chore: Remove Noir builtin comptime mutable methods from macros

[jfecher]

Remake of #21321 since that PR got messed up from a bad merge.

The following functions will be removed from Noir:

FunctionDefinition::add_attribute
FunctionDefinition::set_body
FunctionDefinition::set_parameters
FunctionDefinition::set_return_type
FunctionDefinition::set_return_public
FunctionDefinition::set_return_data
FunctionDefinition::set_unconstrained
Module::add_item
TypeDefinition::add_attribute
TypeDefinition::add_generic
TypeDefinition::set_fields

Only being replaced by the new functions FunctionDefinition::disable and TypeDefinition::add_abi which were the minimal set of functions determined to be needed here so that the Noir team can remove as many of the old mutating functions as possible.

Since the original PR, a call to f.add_attribute("noinitcheck") has been added. I've replaced this with an explicit call to noinitcheck(f) and adding f to a global list of functions that should be considered to have a noinitcheck attribute to keep the check for that attribute working.

[benesjan]

Given this error in the CI run:

account/ecdsa_k_account_contract	error: No method named 'disable' found for type 'FunctionDefinition'
account/ecdsa_k_account_contract	   ┌─ /home/aztec-dev/aztec-packages/noir-projects/aztec-nr/aztec/src/macros/internals_functions_generation/mod.nr:31:9
account/ecdsa_k_account_contract	   │
account/ecdsa_k_account_contract	31 │         function.disable(error_message);
account/ecdsa_k_account_contract	   │         -------------------------------
account/ecdsa_k_account_contract	   │

Is this waiting for a new Noir to be synced to the repo?

[jfecher]

Is this waiting for a new Noir to be synced to the repo?

Yep. We're looking at doing it in #21766. Main issue is that the deny warnings argument means we can't deprecate anything in the noir stdlib without it being a breaking change here. So #21766 is currently including both this change and the compiler update together. We merged another PR into nargo to not deprecate the old methods instead for now.

[vezenovm]

@critesjosh @sklppy88 do you know why the docs deploy may be failing here?

[jfecher]

Another bad squash. Embarrassing. Apologies for the extra review requests.

This PR should be ready to go now - unsure why docs seem to be using old noir versions without the new methods added in #21566.

[critesjosh]

i updated the branch to see if it resolves the docs failure

[critesjosh]

it looks like netlify (where our docs are hosted and built) does not compile noir from source, it downloads a nightly binary using noirup and its not getting the right one. im looking into it

[critesjosh]

I just cleared the netlify cache and rebuilt and it looks like its working

[benesjan]

@jfecher introducing the extra global var for the only self function was unnecessary as we can just check for the only self attribute directly. Simplified that in 045a96e

Now it looks good to merge 👍

[benesjan]

Failed to reproduce the failure of e2e_offchain_payment.test.ts locally so it's probably just a flake.

Will try to re-run and then bother someone with it

[AztecBot]

❌ Failed to cherry-pick to v4-next due to conflicts. (🤖) View backport run.