feat: merge-train/barretenberg#22041
Merged
Merged
Conversation
In the case that the proof size is mis-specified in a noir program performing honk recursion, this will provide a meaningful error.
Collaborator
Author
|
🤖 Auto-merge enabled after 4 hours of inactivity. This PR will be merged automatically once all checks pass. |
## Summary - Merge `next` into `merge-train/barretenberg` to catch up on ~25+ commits - The automated merge-next workflow has been failing silently due to a GitHub ruleset requiring PRs for `merge-train/*` branches (GH013 error) --------- Co-authored-by: spypsy <spypsy@outlook.com> Co-authored-by: spypsy <spypsy@users.noreply.github.com> Co-authored-by: Michal Rzeszutko <michal.rzeszutko@gmail.com> Co-authored-by: Martin Verzilli <martin@aztec-labs.com> Co-authored-by: Nicolas Chamo <nicolas@chamo.com.ar> Co-authored-by: Aztec Bot <49558828+AztecBot@users.noreply.github.com> Co-authored-by: Nicolás Venturo <nicolas.venturo@gmail.com> Co-authored-by: Gregorio Juliana <gregojquiros@gmail.com> Co-authored-by: Jan Beneš <janbenes1234@gmail.com> Co-authored-by: Esau <esau@aztec-labs.com> Co-authored-by: PhilWindle <60546371+PhilWindle@users.noreply.github.com> Co-authored-by: esau <152162806+sklppy88@users.noreply.github.com> Co-authored-by: Alex Gherghisan <alexghr@users.noreply.github.com> Co-authored-by: Josh Crites <jc@joshcrites.com> Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Co-authored-by: ludamad <adam.domurad@gmail.com> Co-authored-by: Phil Windle <philip.windle@gmail.com> Co-authored-by: critesjosh <18372439+critesjosh@users.noreply.github.com> Co-authored-by: David Banks <47112877+dbanks12@users.noreply.github.com> Co-authored-by: AztecBot <tech@aztec-labs.com> Co-authored-by: jfecher <13188781+jfecher@users.noreply.github.com> Co-authored-by: benesjan <benesjan@users.noreply.github.com> Co-authored-by: Maxim Vezenov <mvezenov@gmail.com> Co-authored-by: johnathan79717 <511655+johnathan79717@users.noreply.github.com> Co-authored-by: Ilyas Ridhuan <ilyas@aztecprotocol.com>
johnathan79717
requested review from
a team,
IlyasRidhuan,
LeilaWang,
Maddiaa0,
charlielye,
dbanks12,
fcarreiro,
jeanmon,
nventuro and
sirasistant
as code owners
johnathan79717
removed request for
a team,
IlyasRidhuan,
LeilaWang,
Maddiaa0,
charlielye,
dbanks12,
fcarreiro,
jeanmon,
nventuro and
sirasistant
## Summary - `ci-barretenberg` now uses `make bb-cpp-native-tests` instead of calling `barretenberg/cpp/bootstrap.sh ci` directly - `ci-barretenberg-full` now uses `make bb-tests bb-full-tests` instead of `barretenberg/bootstrap.sh ci` - Adds `bb-crs` as a dependency of `bb-cpp-native-tests` This ensures dependencies like `bb-crs` are resolved automatically by Make, fixing test failures when `bn254_g1_compressed.dat` is missing from the CRS cache (e.g. `CrsFactory.Bn254CompressedChunkHash` tests). Previously, `ci-barretenberg` called `barretenberg/cpp/bootstrap.sh ci` directly, which never ran the CRS download step. The underlying build and test functions are unchanged; only the orchestration layer switches from direct bootstrap.sh calls to Make targets. ## Test plan - [ ] `ci-barretenberg` label triggers the same build+test flow via Make - [ ] `ci-barretenberg-full` label triggers the same full build+test flow via Make - [ ] CRS tests (CrsFactory.Bn254CompressedChunkHash*) pass even without pre-baked CRS in the AMI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BEGIN_COMMIT_OVERRIDE
chore: error in honk rec constraint creation for bad proof size (#21974)
chore: merge next into merge-train/barretenberg (#22049)
refactor: use Make targets for ci-barretenberg CI paths (#22061)
END_COMMIT_OVERRIDE