refactor: use Make targets for ci-barretenberg CI paths#22061
Merged
johnathan79717 merged 1 commit intoMar 26, 2026
Conversation
…cy resolution ci-barretenberg now uses `make bb-cpp-native-tests` instead of calling barretenberg/cpp/bootstrap.sh ci directly. ci-barretenberg-full uses `make bb-tests bb-full-tests` instead of barretenberg/bootstrap.sh ci. This ensures dependencies like bb-crs are resolved automatically by Make, fixing test failures when bn254_g1_compressed.dat is missing from the CRS cache (e.g. CrsFactory.Bn254CompressedChunkHash tests). Also adds bb-crs as an explicit dependency of bb-cpp-native-tests.
Collaborator
|
are we now downloading the CRS in CI each time? no right? |
Collaborator
|
we want to use the existing mount |
Contributor
Author
|
I may need to update the AMI to make sure it's already in the mount. |
AztecBot
added a commit
that referenced
this pull request
Apr 3, 2026
PR #22061 switched ci-barretenberg from calling bootstrap.sh ci (which builds AND runs tests) to make targets that only collect test commands into /tmp/test_cmds without starting the test engine to execute them. This meant BB tests silently stopped running on merge-train/barretenberg PRs. Revert to calling bootstrap.sh ci directly. For ci-barretenberg, add explicit CRS download (the original motivation for #22061). For ci-barretenberg-full, barretenberg/bootstrap.sh already handles CRS download in bootstrap_all.
3 tasks
ludamad
pushed a commit
that referenced
this pull request
Apr 3, 2026
## Summary PR #22061 switched `ci-barretenberg` and `ci-barretenberg-full` from calling `bootstrap.sh ci` (which builds AND runs tests via `parallelize`) to Make targets that only collect test commands into `/tmp/test_cmds` without ever starting the test engine to execute them. This meant BB tests silently stopped running on all `merge-train/barretenberg` PRs. **Fix**: Revert to calling `bootstrap.sh ci` directly. - `ci-barretenberg`: Add explicit CRS download before `barretenberg/cpp/bootstrap.sh ci` (preserving the CRS fix that #22061 was trying to solve) - `ci-barretenberg-full`: Revert to `barretenberg/bootstrap.sh ci` (which already downloads CRS via `bootstrap_all`) ## Test plan - [ ] `ci-barretenberg` label triggers build + test execution (not just build) - [ ] `ci-barretenberg-full` label triggers full build + test execution - [ ] CRS tests pass (the original motivation for #22061) ClaudeBox log: https://claudebox.work/s/0b1cdb0a4d7a7f5a?run=2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ci-barretenbergnow usesmake bb-cpp-native-testsinstead of callingbarretenberg/cpp/bootstrap.sh cidirectlyci-barretenberg-fullnow usesmake bb-tests bb-full-testsinstead ofbarretenberg/bootstrap.sh cibb-crsas a dependency ofbb-cpp-native-testsThis ensures dependencies like
bb-crsare resolved automatically by Make, fixing test failures whenbn254_g1_compressed.datis missing from the CRS cache (e.g.CrsFactory.Bn254CompressedChunkHashtests). Previously,ci-barretenbergcalledbarretenberg/cpp/bootstrap.sh cidirectly, which never ran the CRS download step.The underlying build and test functions are unchanged; only the orchestration layer switches from direct bootstrap.sh calls to Make targets.
Test plan
ci-barretenberglabel triggers the same build+test flow via Makeci-barretenberg-fulllabel triggers the same full build+test flow via Make