fix: skip MsgpackRejectsNonCanonical test in WASM builds#22335
Merged
Conversation
AztecBot
added
ci-draft
iakovenkos
approved these changes
Apr 6, 2026
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Apr 6, 2026
BEGIN_COMMIT_OVERRIDE fix: reject VK with log_circuit_size=0 in UltraKeccak verifier (#22319) chore: merkle tree audit 2 (#21475) fix: graceful failures in verifier code paths + other fixes (#22311) fix: Fr::from_u64 big-endian encoding to match C++ msgpack format (#22233) fix: corrupt low-order bytes in batch verifier test to avoid non-canonical field encoding (#22333) fix: skip MsgpackRejectsNonCanonical test in WASM builds (#22335) END_COMMIT_OVERRIDE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes WASM CI failure for
PrimeFieldTest/0.MsgpackRejectsNonCanonicalinecc_tests.WASM builds define
BB_NO_EXCEPTIONS, which makesthrow_or_abort()callabort()instead of throwingstd::runtime_error. The test usesEXPECT_THROWwhich cannot catch an abort — the WASM process crashes withwasm trap: unreachable.Wraps the test with
#ifndef BB_NO_EXCEPTIONSand adds aGTEST_SKIP()fallback, matching the existing pattern inc_bind_exception.test.cpp.Test plan
ecc_tests --gtest_filter=*MsgpackRejectsNonCanonical*— all 6 field types pass on native buildClaudeBox log: https://claudebox.work/s/e5146dc92fea29dd?run=3