Skip to content

fix: skip MsgpackRejectsNonCanonical test in WASM builds #22335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iakovenkos merged 1 commit into from
Apr 6, 2026
Merged

fix: skip MsgpackRejectsNonCanonical test in WASM builds #22335

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions barretenberg/cpp/src/barretenberg/ecc/fields/prime_field.test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -615,6 +615,9 @@ TYPED_TEST(PrimeFieldTest, Msgpack)
EXPECT_EQ(actual, expected);
}

// This test requires exception support; in WASM builds (BB_NO_EXCEPTIONS),
// throw_or_abort calls abort() instead of throwing, so EXPECT_THROW cannot work.
#ifndef BB_NO_EXCEPTIONS
TYPED_TEST(PrimeFieldTest, MsgpackRejectsNonCanonical)
{
using F = TypeParam;
Expand Down Expand Up @@ -654,6 +657,12 @@ TYPED_TEST(PrimeFieldTest, MsgpackRejectsNonCanonical)
},
std::runtime_error);
}
#else
TYPED_TEST(PrimeFieldTest, MsgpackRejectsNonCanonical)
{
GTEST_SKIP() << "Skipping: throw_or_abort calls abort() when BB_NO_EXCEPTIONS is defined";
}
#endif

// ================================
// Montgomery Form Conversion Tests (254-bit fields)
Expand Down
Loading