Skip to content

fix(p2p): back off on repeated auth handshake failures#22435

Merged
spypsy merged 1 commit into
merge-train/spartanfrom
spyros/a-738-audit-62-peermanager-reconnect-loop-doesnt-back-off-on
Apr 10, 2026
Merged

fix(p2p): back off on repeated auth handshake failures#22435
spypsy merged 1 commit into
merge-train/spartanfrom
spyros/a-738-audit-62-peermanager-reconnect-loop-doesnt-back-off-on

Conversation

@spypsy

@spypsy spypsy commented Apr 9, 2026

Copy link
Copy Markdown
Member
  • Gate outbound peer dials with the same isNodeAllowedToConnect check already used for inbound connections, so peers that exceed the auth-failure threshold are no longer re-dialed
  • Add auth-failed peers to timedOutPeers with exponential backoff (5 min base, doubling up to ~2.5 hours), preventing a rapid connect-auth-fail-disconnect-redial loop
  • Remove auth-failed peers from cachedPeers so they aren't retried on the next heartbeat

Fixes A-738

@spypsy spypsy marked this pull request as ready for review April 9, 2026 12:41
@spypsy spypsy merged commit 89d2f04 into merge-train/spartan Apr 10, 2026
22 checks passed
@spypsy spypsy deleted the spyros/a-738-audit-62-peermanager-reconnect-loop-doesnt-back-off-on branch April 10, 2026 09:39
github-merge-queue Bot pushed a commit that referenced this pull request Apr 11, 2026
BEGIN_COMMIT_OVERRIDE
fix(p2p): back off on repeated auth handshake failures (#22435)
chore(pipeline): add metrics for pipeling building timelines (#21591)
fix: no division by zero in sentinel (#22467)
chore(pipelining): update next net  (#22466)
feat(claude): add skill to read gists (#22471)
feat(node): add fee prediction API for upcoming L2 slots (#22116)
fix: lower EXPECTED_BLOCKS_PER_CHECKPOINT for CI stability (#22480)
END_COMMIT_OVERRIDE
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants