chore(pipeline): add metrics for pipeling building timelines#21591
Merged
Conversation
This was referenced Mar 16, 2026
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Maddiaa0
force-pushed
the
md/update-latency-explorer
branch
from
3850b5a to
94d5685
Compare
Maddiaa0
force-pushed
the
md/further-pipeline-overlapping
branch
from
e636f49 to
3a1ba92
Compare
Maddiaa0
force-pushed
the
md/further-pipeline-overlapping
branch
from
3a1ba92 to
6b3361c
Compare
Maddiaa0
force-pushed
the
md/update-latency-explorer
branch
from
94d5685 to
5c7471a
Compare
Maddiaa0
force-pushed
the
md/further-pipeline-overlapping
branch
from
6b3361c to
94cdd36
Compare
Maddiaa0
force-pushed
the
md/update-latency-explorer
branch
from
5c7471a to
2e68fe2
Compare
Maddiaa0
changed the base branch from
md/update-latency-explorer
to
graphite-base/21591
Maddiaa0
force-pushed
the
md/further-pipeline-overlapping
branch
from
94cdd36 to
6da9164
Compare
Maddiaa0
force-pushed
the
graphite-base/21591
branch
from
2e68fe2 to
191d1bb
Compare
Maddiaa0
changed the base branch from
graphite-base/21591
to
md/update-latency-explorer
Maddiaa0
force-pushed
the
md/further-pipeline-overlapping
branch
from
6da9164 to
dea8538
Compare
Maddiaa0
force-pushed
the
md/update-latency-explorer
branch
2 times, most recently
from
63f38ed to
df9a22b
Compare
Maddiaa0
force-pushed
the
md/further-pipeline-overlapping
branch
from
dea8538 to
3009e59
Compare
spalladino
reviewed
Mar 31, 2026
spalladino
left a comment
spalladino
left a comment
Contributor
There was a problem hiding this comment.
Reading the PR I'm not sure I understand the rationale for this. Why do we need to shorten specifically the last block? If we want to allow more time at the end of the slot for assembling the checkpoint, we can bump the CHECKPOINT_ASSEMBLE_TIME, and reduce the time for all blocks proportionally (or the number of blocks for that matter), so we don't have an edge case when handling the very last block.
Maddiaa0
changed the base branch from
md/update-latency-explorer
to
graphite-base/21591
Maddiaa0
force-pushed
the
graphite-base/21591
branch
from
df9a22b to
59aca30
Compare
Maddiaa0
force-pushed
the
md/further-pipeline-overlapping
branch
from
3009e59 to
942c73e
Compare
Maddiaa0
force-pushed
the
graphite-base/21591
branch
from
59aca30 to
8fd3bbe
Compare
Maddiaa0
force-pushed
the
md/further-pipeline-overlapping
branch
from
942c73e to
25ca323
Compare
Maddiaa0
force-pushed
the
graphite-base/21591
branch
from
8fd3bbe to
0c09382
Compare
Maddiaa0
force-pushed
the
md/further-pipeline-overlapping
branch
from
25ca323 to
87abfed
Compare
spalladino
approved these changes
Apr 8, 2026
Maddiaa0
force-pushed
the
md/further-pipeline-overlapping
branch
from
87abfed to
a21bee9
Compare
Maddiaa0
changed the base branch from
graphite-base/21591
to
merge-train/spartan
Maddiaa0
force-pushed
the
md/further-pipeline-overlapping
branch
2 times, most recently
from
d705812 to
6eba91a
Compare
Maddiaa0
changed the title
Maddiaa0
force-pushed
the
md/further-pipeline-overlapping
branch
2 times, most recently
from
fe17f27 to
98f8e36
Compare
spalladino
approved these changes
Apr 10, 2026
spalladino
left a comment
spalladino
left a comment
Contributor
There was a problem hiding this comment.
Looks good! Just a heads up: if we add a metric to track when the checkpoint is sent to L1, that may overlap with the starting of the next checkpoint if handled by the same proposer.
Maddiaa0
force-pushed
the
md/further-pipeline-overlapping
branch
4 times, most recently
from
06170d8 to
ea38e95
Compare
Maddiaa0
force-pushed
the
md/further-pipeline-overlapping
branch
from
ea38e95 to
acb2191
Compare
This was referenced Apr 10, 2026
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Apr 11, 2026
BEGIN_COMMIT_OVERRIDE fix(p2p): back off on repeated auth handshake failures (#22435) chore(pipeline): add metrics for pipeling building timelines (#21591) fix: no division by zero in sentinel (#22467) chore(pipelining): update next net (#22466) feat(claude): add skill to read gists (#22471) feat(node): add fee prediction API for upcoming L2 slots (#22116) fix: lower EXPECTED_BLOCKS_PER_CHECKPOINT for CI stability (#22480) END_COMMIT_OVERRIDE
critesjosh
pushed a commit
that referenced
this pull request
Apr 14, 2026
## Overview Metrics to keep an eye on checkpoint construction
This was referenced Apr 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Metrics to keep an eye on checkpoint construction