fix: external audit fixes for Keccak#22436
Merged
Merged
Conversation
…nt and hash_field_elements in native keccak
ledwards2225
approved these changes
Apr 10, 2026
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Apr 13, 2026
BEGIN_COMMIT_OVERRIDE fix: skip heavy recursion tests in debug builds (#22446) fix: add clear error for unsatisfiable ACIR AssertZero opcode (#22417) feat: enforce accumulator_not_empty = 0 at ECCVM lagrange_first row (#22461) fix: skip heavy recursion tests in debug builds, keep one for assertion coverage (#22389) fix: external audit fixes for Pedersen (#22434) chore!: fix BASE off-by-one in create_small_range_constraint in theta step of keccak (#22404) fix: external audit fixes for Keccak (#22436) fix: external audit fixes for BLAKE (#22443) chore: misc hash gadget updates (#22452) END_COMMIT_OVERRIDE
critesjosh
pushed a commit
that referenced
this pull request
Apr 14, 2026
**finding 7: inverted assertion in keccak fuzzer** --- fixed 4da6a65 The keccak fuzzer had an inverted assertion in the circuit checker. This has been fixed. **finding 10: delete dead code pertaining to `hash_field_element`** --- fixed 940f6e4 `hash_field_element` and `hash_field_elements` constitute dead code, which was missed to be removed in the internal audit. These have been deleted now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
finding 7: inverted assertion in keccak fuzzer --- fixed 4da6a65
The keccak fuzzer had an inverted assertion in the circuit checker. This has been fixed.
finding 10: delete dead code pertaining to
hash_field_element--- fixed 940f6e4hash_field_elementandhash_field_elementsconstitute dead code, which was missed to be removed in the internal audit. These have been deleted now.