fix: passing in user call info from wallet (backport #21937)#22459
Merged
Thunkar merged 4 commits intoApr 10, 2026
Conversation
Cherry-pick of a186a55 with conflict markers preserved.
Resolved conflicts in batch_call.ts and batch_call.test.ts: - Removed unused TxSimulationResult and HashedValues imports - Used TxSimulationResultWithAppOffset type for simulatedTx variable - Used getPrivateReturnValuesOfAppCall instead of getPrivateReturnValues
AztecBot
added
ci-draft
Thunkar
approved these changes
Apr 10, 2026
Thunkar
added a commit
that referenced
this pull request
Apr 10, 2026
BEGIN_COMMIT_OVERRIDE cherry-pick: fix: passing in user call info from wallet (#21937) fix: passing in user call info from wallet (backport #21937) (#22459) fix: prepopulated scopes in simulateviaentrypoint (#22464) chore: backport #22464 (fix: prepopulated scopes in simulateviaentrypoint) to v4-next (#22470) docs: add macOS prerequisites and improve Node.js version guidance (#22408) END_COMMIT_OVERRIDE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Backport of #21937 to v4-next.
Robustly handles selection of return value when simulating private function by passing in the information of which call corresponds to the return value "user intends to get" from the wallet via
TxSimulationResultWithAppOffset.Cherry-pick conflicts resolved
batch_call.ts: Removed staleTxSimulationResultimport, usedTxSimulationResultWithAppOffset, added non-null assertions for the now-optionalsimulatedTxvariablebatch_call.test.ts: AddedNestedProcessReturnValuesimport (needed by test), removed unusedHashedValuesCommit structure
Original PR by @benesjan.
ClaudeBox log: https://claudebox.work/s/c28e647e71336658?run=2