fix: prepopulated scopes in simulateviaentrypoint#22464
Merged
Conversation
mverzilli
approved these changes
Apr 10, 2026
mverzilli
approved these changes
Apr 10, 2026
Collaborator
|
❌ Failed to cherry-pick to |
AztecBot
pushed a commit
that referenced
this pull request
Apr 10, 2026
This is a bug, was causing problems since the method receives scopes pre-populated. Fixing it surfaced another issue @spalladino was running into, which is that our account contract stubs do not provide a constructor. This was causing the cryptic error described here: #22421 This PR creates a stub account contract per account type (since we need the selector to match, and Schnorr/ECDSA have very different constructors) + adds a meaningful error when the proxied contract store doesn't find a method in the stub
Thunkar
added a commit
that referenced
this pull request
Apr 10, 2026
…oint) to v4-next (#22470) ## Summary Backport of #22464 to v4-next. Cherry-pick applied cleanly (no conflicts) thanks to a previous backport that unified the branches. The original PR fixes a bug where scopes were being pre-populated incorrectly in `simulateViaEntrypoint`, and also adds per-account-type stub contracts (splitting `SimulatedAccount` into `SimulatedSchnorrAccount` and `SimulatedEcdsaAccount`).
Thunkar
added a commit
that referenced
this pull request
Apr 10, 2026
BEGIN_COMMIT_OVERRIDE cherry-pick: fix: passing in user call info from wallet (#21937) fix: passing in user call info from wallet (backport #21937) (#22459) fix: prepopulated scopes in simulateviaentrypoint (#22464) chore: backport #22464 (fix: prepopulated scopes in simulateviaentrypoint) to v4-next (#22470) docs: add macOS prerequisites and improve Node.js version guidance (#22408) END_COMMIT_OVERRIDE
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Apr 10, 2026
BEGIN_COMMIT_OVERRIDE fix: prepopulated scopes in simulateviaentrypoint (#22464) END_COMMIT_OVERRIDE
critesjosh
pushed a commit
that referenced
this pull request
Apr 14, 2026
This is a bug, was causing problems since the method receives scopes pre-populated. Fixing it surfaced another issue @spalladino was running into, which is that our account contract stubs do not provide a constructor. This was causing the cryptic error described here: #22421 This PR creates a stub account contract per account type (since we need the selector to match, and Schnorr/ECDSA have very different constructors) + adds a meaningful error when the proxied contract store doesn't find a method in the stub
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a bug, was causing problems since the method receives scopes pre-populated.
Fixing it surfaced another issue @spalladino was running into, which is that our account contract stubs do not provide a constructor. This was causing the cryptic error described here: #22421
This PR creates a stub account contract per account type (since we need the selector to match, and Schnorr/ECDSA have very different constructors) + adds a meaningful error when the proxied contract store doesn't find a method in the stub