fix: fix nightly debug build — PairingPoints assertion crash + test skip list#22549
Closed
AztecBot wants to merge 1 commit into
Closed
fix: fix nightly debug build — PairingPoints assertion crash + test skip list#22549AztecBot wants to merge 1 commit into
AztecBot wants to merge 1 commit into
Conversation
AztecBot
added
ci-draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the recurring nightly barretenberg debug build failure with two independent fixes:
PairingPoints debug assertion crash: The
#ifndef NDEBUGnative pairing point validation throws when witness values are zero-initialized (during VK generation). Wraps in try-catch so it logs instead of crashing. No effect on release builds.Heavy recursion test timeouts: Adds skip list for 12 recursive verifier test suites that take 400-600s+ in debug mode. Preserves
WithoutPredicate/1.GenerateVKFromConstraintswhich exercises the debug-onlynative_verification_debugcode path. Cherry-picked from merge-train/barretenberg PR fix: skip heavy recursion tests in debug builds to fix nightly CI #22521 which hasn't landed onnextyet.Supersedes stale drafts #22518, #22548, and #22040.
Full analysis: https://gist.github.com/AztecBot/542928363e60e54e9575ab768bb531e6
Verification
ChonkRecursionConstraintTest.GenerateRecursiveChonkVerifierVKFromConstraints— was crashing, now passesClaudeBox log: https://claudebox.work/s/ec6b6427c03132f8?run=1