Skip to content

fix: fix nightly debug build — PairingPoints assertion crash + test skip list #22549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AztecBot wants to merge 1 commit into from
+22 −4
Closed

fix: fix nightly debug build — PairingPoints assertion crash + test skip list #22549

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions barretenberg/cpp/bootstrap.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,6 +243,15 @@ function test_cmds_native {
awk '/^[a-zA-Z]/ {suite=$1} /^[ ]/ {print suite$1}' | \
grep -v 'DISABLED_' | \
while read -r test; do
# Skip heavy recursion tests in debug builds — they take 400-600s+ and the same
# code paths are already exercised (with assertions) by faster tests in the suite.
# Keep WithoutPredicate/1.GenerateVKFromConstraints so that the debug-only
# native_verification_debug path in honk_recursion_constraint.cpp is still exercised.
if [[ "$native_preset" == *debug* ]] && [[ "$test" =~ ^(HonkRecursionConstraintTest|ChonkRecursionConstraintTest|AvmRecursionInnerCircuitTests|AvmRecursionConstraintTest|AvmRecursiveTests\.TwoLayer|PaddingVariants/AvmRecursiveTestsParameterized\.TwoLayer|BoomerangTwoLayerAvmRecursiveVerifierTests|ECCVMRecursiveTests|GoblinRecursiveVerifierTests|GoblinAvmRecursiveVerifierTests|BoomerangGoblinRecursiveVerifierTests|BoomerangGoblinAvmRecursiveVerifierTests) ]]; then
if [[ "$test" != "HonkRecursionConstraintTestWithoutPredicate/1.GenerateVKFromConstraints" ]]; then
continue
fi
fi
local prefix=$hash
# A little extra resource for these tests.
# IPARecursiveTests fails with 2 threads.
Expand Down
17 changes: 13 additions & 4 deletions barretenberg/cpp/src/barretenberg/stdlib/primitives/pairing_points.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,12 @@ template <typename Curve> struct PairingPoints {
}

#ifndef NDEBUG
bb::PairingPoints<typename Curve::NativeCurve> native_pp(P0().get_value(), P1().get_value());
info("Are Pairing Points with tag ", tag_index, " valid? ", native_pp.check() ? "true" : "false");
try {
bb::PairingPoints<typename Curve::NativeCurve> native_pp(P0().get_value(), P1().get_value());
info("Are Pairing Points with tag ", tag_index, " valid? ", native_pp.check() ? "true" : "false");
} catch (const std::exception& e) {
info("Pairing Points with tag ", tag_index, " native check skipped: ", e.what());
}
#endif
}

Expand Down Expand Up @@ -210,8 +214,13 @@ template <typename Curve> struct PairingPoints {
}

#ifndef NDEBUG
bb::PairingPoints<typename Curve::NativeCurve> native_pp(P0().get_value(), P1().get_value());
info("Are aggregated Pairing Points with tag ", tag_index, " valid? ", native_pp.check() ? "true" : "false");
try {
bb::PairingPoints<typename Curve::NativeCurve> native_pp(P0().get_value(), P1().get_value());
info(
"Are aggregated Pairing Points with tag ", tag_index, " valid? ", native_pp.check() ? "true" : "false");
} catch (const std::exception& e) {
info("Aggregated Pairing Points with tag ", tag_index, " native check skipped: ", e.what());
}
#endif
}

Expand Down
Loading