feat: merge-train/fairies#22591
Merged
Merged
Conversation
## Summary - Adds a `check_noir_release_assets` function to root `bootstrap.sh` that queries the GitHub API to verify the noir release has nargo binary assets - Called from the `ci-release` case, right after semver validation and before the build starts -- so it fails fast and only runs during releases - Prevents releases like `v4.2.0-aztecnr-rc.2` where the noir tag existed but had no binaries, causing 404 errors when users ran `noirup` ## Test plan - [x] Verified `gh release view` query returns correct asset count against a known noir release (`v1.0.0-beta.3` → 5 assets) - [ ] CI passes Fixes https://linear.app/aztec-labs/issue/F-506/check-noir-binaries-exist-on-release --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
A wallet is instantiated for a particular chain, and if an app supports multiple it is expected to recreate the whole thing. We are calling `getChainInfo` a surprising amount of times, so it makes sense to cache it for performance. --------- Co-authored-by: benesjan <janbenes1234@gmail.com>
The recent relaxation of contract scope sync to increase concurrency exposed a latent issue in the `getCapsule` method of `CapsuleStore`. This method was not wrapped in `transactionAsync`, which was fine due to the architecture ensuring it wouldn't race other transactions. With multiple syncs running concurrently, that guarantee is no longer a given, so we need to be more defensive.
Tracking down potential indexeddb stale transactions --------- Co-authored-by: mverzilli <martin@aztec-labs.com>
…stack]` (#22593) In this PR I add the testing infrastructure that allows us to test new contract artifacts (artifacts from the release that will be getting build) with an old release of a stack. To achieve this I expose a Wallet service over JSON-RPC and then connect it to via wallet client from an e2e test. In this PR I get this to work but it's not yet integrated into the CI release process - this makes sense to do after the next release as at that point we will have a release we can start testing against (e.g. to test release 10 I need release 9 to already contain this code such that I can spin up the wallet service from release 9 - this implies integrating this will make sense in like 2 weeks). Also in this PR I only refactored the `e2e_amm` which is not sufficient to test the full oracle suite but it makes sense to add more tests in a followup to keep the scope small. `e2e_amm` tests well enough that the new infra works. For more context see [this slack discussion](https://aztecprotocol.slack.com/archives/C07R3GTKJ49/p1776137361334029). ## Summary - Adds `createWalletClient(url)` thin RPC client in `aztec.js` for connecting to a remote wallet service over JSON-RPC - Adds `wallet_service.ts` standalone entrypoint in `end-to-end` that spins up a local Aztec network + EmbeddedWallet and serves both over HTTP RPC (test-only, NOT in the `aztec` binary) - Adds `docker-compose.yml` for forward-compat testing with old-stack (old release image) and new-tree test containers - Adds refactored `e2e_amm.test.ts` in `backwards-compat/` using standard `Wallet` interface and remote wallet RPC Closes [F-552](https://linear.app/aztec-labs/issue/F-552/infrastructure-for-testing-new-contract-artfiacts-old-aztec-stack) --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Collaborator
Author
|
🤖 Auto-merge enabled after 4 hours of inactivity. This PR will be merged automatically once all checks pass. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BEGIN_COMMIT_OVERRIDE
feat: check noir release has nargo binaries before releasing (#22551)
chore: cache chainInfo in embeddedwallet (#22592)
fix: wrap external getCapsule in transactionAsync (#22595)
fix(pxe): throw clear error for invalid comparator in pick_notes (#22585)
refactor(aztec-nr): rename conversion fns to encode_/decode_ naming (#22576)
fix: adding transactions to PXE stores (#22603)
feat: infrastructure for testing
[new_contract_artfiacts, old_aztec_stack](#22593)chore: fix unnecessary and inconsistent side-effect counter increments (#22245)
feat(aztec-nr): new BoundedVec emit private log APIs (#22064)
END_COMMIT_OVERRIDE