fix: adding transactions to PXE stores#22603
Merged
Merged
Conversation
mverzilli
reviewed
Apr 16, 2026
|
|
||
| const skM = GrumpkinScalar.fromBuffer(skMBuffer); | ||
| // The remaining awaits are non-DB computations. They are safe because no further IDB operations follow them. | ||
| const computedPkMHash = await pkM.hash(); |
Contributor
There was a problem hiding this comment.
this will close the idb tx, which now is fine because this is happening inside a transactionAsync env and there are no further db ops after.
mverzilli
approved these changes
Apr 16, 2026
mverzilli
left a comment
mverzilli
left a comment
Contributor
There was a problem hiding this comment.
Looks good (what a pain)
AztecBot
pushed a commit
that referenced
this pull request
Apr 16, 2026
Tracking down potential indexeddb stale transactions --------- Co-authored-by: mverzilli <martin@aztec-labs.com>
Collaborator
|
✅ Successfully backported to backport-to-v4-next-staging #22580. |
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Apr 17, 2026
BEGIN_COMMIT_OVERRIDE feat: check noir release has nargo binaries before releasing (#22551) chore: cache chainInfo in embeddedwallet (#22592) fix: wrap external getCapsule in transactionAsync (#22595) fix(pxe): throw clear error for invalid comparator in pick_notes (#22585) refactor(aztec-nr): rename conversion fns to encode_/decode_ naming (#22576) fix: adding transactions to PXE stores (#22603) feat: infrastructure for testing `[new_contract_artfiacts, old_aztec_stack]` (#22593) chore: fix unnecessary and inconsistent side-effect counter increments (#22245) feat(aztec-nr): new BoundedVec emit private log APIs (#22064) END_COMMIT_OVERRIDE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracking down potential indexeddb stale transactions