fix: handle missing L1 finalized block on devnets#22663
Merged
spalladino merged 1 commit intoApr 21, 2026
Conversation
Adds getFinalizedL1Block helper that returns undefined when the L1 chain does not yet have a finalized block (common on freshly-started devnets) and uses it in the archiver and epoch-cache call sites.
spalladino
force-pushed
the
spl/fix/handle-missing-l1-finalized-block
branch
from
03cde8b to
43fc41a
Compare
spypsy
approved these changes
Apr 21, 2026
chrismarino
pushed a commit
to chrismarino/aztec-packages
that referenced
this pull request
May 5, 2026
BEGIN_COMMIT_OVERRIDE fix(kv-store): ensure LMDB cursor is closed on iteration abort (AztecProtocol#22509) fix(telemetry-client): use appropriate histogram buckets for L1 gas prices (AztecProtocol#22512) fix(telemetry-client): log warning when BatchSpanProcessor drops spans (AztecProtocol#22511) fix(stdlib): wrap HA signer databaseUrl in SecretValue (AztecProtocol#22510) fix(prover-client): don't mark in-progress epoch N jobs as stale when epoch N+1 starts (AztecProtocol#22508) chore: (A-730) graceful shutdown for services in node startup failure path (AztecProtocol#22112) fix(prover-client): reject stale job promises and count timeouts toward retry limit (AztecProtocol#21842) feat(archiver): validate historical L1 log availability at startup (AztecProtocol#22644) fix(archiver): do not query MessageSent events by blockhash (AztecProtocol#22641) refactor(e2e): skip initial sequencer in p2p and epochs tests (AztecProtocol#22535) fix: handle missing L1 finalized block on devnets (AztecProtocol#22663) fix(world-state): treat historical block 0 queries as historical, not latest (AztecProtocol#22679) fix(sequencer): re-check parent checkpoint validity before pipelined L1 submission (AztecProtocol#22586) fix(world-state): make block 0 a first-class historical block (AztecProtocol#22711) chore: show all running versions (AztecProtocol#22376) chore: fix prettier inside worktrees (AztecProtocol#22557) feat: use optimized verifier for rollup (AztecProtocol#21840) fix(kv-store): skip pool creation on ephemeral deleteDb to unstick browser tests (AztecProtocol#22693) chore: rm claude lockfile (AztecProtocol#22718) fix(e2e): wait for first checkpoint in fee_asset_price_oracle_gossip test (AztecProtocol#22719) chore(prover-node): track estimated L1 fee when proof publishing is disabled (AztecProtocol#22691) fix(ci): rerun squashed PR check on base branch change (AztecProtocol#22713) feat(archiver): decouple calldata from blob fetching in L1 synchronizer (AztecProtocol#22716) refactor(e2e): enable pipelining in e2e_epochs tests (AztecProtocol#22544) feat(p2p): reject and evict txs with insufficient max fee per gas (AztecProtocol#22118) refactor(world-state): always index block 0 regardless of initial tree size (AztecProtocol#22724) fix(e2e): fix redistribution test (AztecProtocol#22729) END_COMMIT_OVERRIDE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
On freshly-started L1 devnets (anvil, local geth/reth/nethermind) there is a startup window during which the
finalizedblock tag is not yet available — calls likegetBlock({ blockTag: 'finalized' })fail with a JSON-RPC error instead of returning a block. The archiver currently logs noisy warnings during this window and epoch-cache would crash dereferencing the missing block's timestamp.Approach
Added a shared
getFinalizedL1Blockhelper in@aztec/ethereum/queriesthat returnsundefinedwhen the chain has no finalized block yet, distinguishing that specific failure from other RPC errors by walking the viem error chain for the"finalized|safe block not found"message (the code-32000surfaced by geth/reth/nethermind). All three production call sites now handleundefinedgracefully: the archiver skips the finalized checkpoint update, and epoch-cache treats entries as "not finalized yet" so they continue to refresh on TTL until the L1 chain catches up.Changes
getFinalizedL1Blockhelper andisFinalizedBlockTagNotFoundErrorpredicate inqueries.ts.updateFinalizedCheckpointuses the helper and returns early with a trace log instead of warning; removed the old"returned no data"substring workaround.refreshStaleEntryandfetchAndCacheuse the helper and guard thesamplingTs <= finalizedBlock.timestampcomparison so entries stay unfinalized when L1 has none yet.FakeL1Stateconfigured with no finalized block, and an epoch-cache test asserting entries stay unfinalized and keep refreshing.