Skip to content

fix(spartan): drop broken Terraform validations on RPC ingress vars #22786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexghr merged 3 commits into from
Apr 25, 2026
Merged

fix(spartan): drop broken Terraform validations on RPC ingress vars #22786

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
50212e5
fix(spartan): allow null RPC_INGRESS_LOG_SAMPLE_RATE in Terraform val…
AztecBot Apr 25, 2026
bce7d80
remove validation entirely per review
AztecBot Apr 25, 2026
bffae17
remove RPC_INGRESS_SESSION_AFFINITY validation block too
AztecBot Apr 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions spartan/terraform/deploy-aztec-infra/variables.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -731,23 +731,13 @@ variable "RPC_INGRESS_SESSION_AFFINITY" {
description = "Session affinity type for the RPC BackendConfig. One of NONE, CLIENT_IP, GENERATED_COOKIE. Leave empty for no affinity (GCE default)."
type = string
default = ""

validation {
condition = contains(["", "NONE", "CLIENT_IP", "GENERATED_COOKIE"], var.RPC_INGRESS_SESSION_AFFINITY)
error_message = "RPC_INGRESS_SESSION_AFFINITY must be empty, NONE, CLIENT_IP, or GENERATED_COOKIE."
}
}

variable "RPC_INGRESS_LOG_SAMPLE_RATE" {
description = "LB access-log sample rate for the RPC BackendConfig (0.0-1.0). When set, logs include the Cloud Armor matched rule priority. Leave null to disable logging (GCE default)."
type = number
nullable = true
default = null

validation {
condition = var.RPC_INGRESS_LOG_SAMPLE_RATE == null || (var.RPC_INGRESS_LOG_SAMPLE_RATE >= 0 && var.RPC_INGRESS_LOG_SAMPLE_RATE <= 1)
error_message = "RPC_INGRESS_LOG_SAMPLE_RATE must be null or a float in [0.0, 1.0]."
}
}

variable "PROVER_FAILED_PROOF_STORE" {
Expand Down
Loading