fix(spartan): drop broken Terraform validations on RPC ingress vars#22786
Merged
alexghr merged 3 commits intoApr 25, 2026
Conversation
alexghr
approved these changes
Apr 25, 2026
alexghr
approved these changes
Apr 25, 2026
This was referenced Apr 25, 2026
chrismarino
pushed a commit
to chrismarino/aztec-packages
that referenced
this pull request
May 5, 2026
BEGIN_COMMIT_OVERRIDE chore(node): fix p2p services start-stop (AztecProtocol#22776) fix(spartan): break stale terraform state locks on ephemeral namespaces (AztecProtocol#22777) fix(spartan): drop broken Terraform validations on RPC ingress vars (AztecProtocol#22786) END_COMMIT_OVERRIDE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Nightly Spartan Scenario CI broke on
v5.0.0-nightly.20260425(run). Bothci-network-scenario (1)and(2)jobs died insideterraform planfordeploy-aztec-infraafter about 5 seconds.Root cause
The
RPC_INGRESS_LOG_SAMPLE_RATEvariable added in #21591 (chore: setup CloudDNS and CloudArmor) had this validation:||does not short-circuit inside a Terraform validationcondition— Terraform eagerly evaluates thevar.X >= 0subexpression, andnull >= 0errors withargument must not be null, aborting the plan.next-scenariodoes not set this var, sodeploy_network.shwrites the default literalnullinto the generatedterraform.tfvars, which trips the validation.Yesterday's nightly tag (
v5.0.0-nightly.20260424at848af53aa) was cut before that commit landed.Fix
Drop the validation blocks on the variables that #21591 added:
RPC_INGRESS_LOG_SAMPLE_RATEandRPC_INGRESS_SESSION_AFFINITY. Both are forwarded into the GCE BackendConfig, which validates the values server-side; the Terraform-level checks were duplicating that validation and the LOG_SAMPLE_RATE one was outright broken.Full analysis (failure logs, reproduction, etc.): https://gist.github.com/AztecBot/14f1172ad743662595c1bdc630958d99