refactor(pxe): batch RPC calls for note and event validation#22988
Merged
Conversation
Thunkar
approved these changes
May 6, 2026
Thunkar
left a comment
Thunkar
left a comment
Collaborator
There was a problem hiding this comment.
Lovely! Would feel better if @mverzilli took a look too though
mverzilli
reviewed
May 7, 2026
| */ | ||
| async #fetchTxEffects(txHashes: TxHash[]): Promise<Map<string, IndexedTxEffect>> { | ||
| const uniqueTxHashes = uniqueBy(txHashes, h => h.toString()); | ||
| const fetched = await Promise.all(uniqueTxHashes.map(h => this.aztecNode.getTxEffect(h))); |
Contributor
There was a problem hiding this comment.
some thoughts that came to mind looking at this:
- "oh it would be nice if the node let us ask for a bunch of txeffects in one request"
- "oh but that could damage privacy"
- "oh but if the node wanted to harm us actually they would see a history of very close txeffects anyway in their logs"
Contributor
Author
There was a problem hiding this comment.
We assume that the node has good intentions, so we could consider this in the future
AztecBot
pushed a commit
that referenced
this pull request
May 7, 2026
Collaborator
|
✅ Successfully backported to backport-to-v4-next-staging #23032. |
Thunkar
added a commit
that referenced
this pull request
May 7, 2026
BEGIN_COMMIT_OVERRIDE refactor(pxe): batch RPC calls for note and event validation (#22988) END_COMMIT_OVERRIDE
rangozd
pushed a commit
to rangozd/aztec-packages
that referenced
this pull request
May 16, 2026
BEGIN_COMMIT_OVERRIDE refactor: `getPackageVersion` fn cleanup (AztecProtocol#22941) fix(ci): skip acceptance test for canary -commit. tags (AztecProtocol#22951) fix: closing db, correct stub side effects (AztecProtocol#22939) feat: wallet-sdk heartbeat (AztecProtocol#22948) chore: pxe db schema compatibility test (AztecProtocol#22872) feat: stamping aztec version into contract artifacts (AztecProtocol#22550) fix: add aztecVersion to PXE schema_tests fixture (AztecProtocol#22960) feat(pxe): deduplicate class ID verification per contract (AztecProtocol#22966) chore: add noirfmt.toml to noir-contracts and run nargo fmt (AztecProtocol#22971) feat(aztec-nr): Initial handshake registry contract with non interactive handshake function (AztecProtocol#22854) chore: merge next into merge-train/fairies (AztecProtocol#22991) fix(aztec-up): Aztec installer does not shadow user installed binaries on PATH (AztecProtocol#22902) test(ci): drop e2e_kernelless_simulation from backwards-compat e2e (AztecProtocol#23005) feat(ci): notify #team-fairies when backwards-compat e2e fails on nightly (AztecProtocol#23006) chore: merge next into merge-train/fairies (AztecProtocol#23021) fix: better DeployMethod (AztecProtocol#22985) refactor(pxe): batch RPC calls for note and event validation (AztecProtocol#22988) END_COMMIT_OVERRIDE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
uniqueByutility to the foundation collection library for deduplicating arrays by a key function