Skip to content

refactor(pxe): use findLeavesIndexes for read request verification#23123

Merged
nchamo merged 3 commits into
merge-train/fairiesfrom
nchamo/perf-batch-read-request-verification
May 11, 2026
Merged

refactor(pxe): use findLeavesIndexes for read request verification#23123
nchamo merged 3 commits into
merge-train/fairiesfrom
nchamo/perf-batch-read-request-verification

Conversation

@nchamo

@nchamo nchamo commented May 9, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Replace per-read-request getNoteHashMembershipWitness / getNullifierMembershipWitness calls with a single batched findLeavesIndexes call per tree when verifying settled read requests in verifyReadRequests.
  • We only need existence here, not the witness, so the cheaper batched lookup suffices.

@nchamo nchamo added the ci-draft Run CI on draft PRs. label May 9, 2026
@nchamo nchamo self-assigned this May 9, 2026
@nchamo nchamo changed the title perf(pxe): use findLeavesIndexes for read request verification refactor(pxe): use findLeavesIndexes for read request verification May 9, 2026
@nchamo nchamo added the ci-no-fail-fast Sets NO_FAIL_FAST in the CI so the run is not aborted on the first failure label May 9, 2026
@AztecBot

AztecBot commented May 9, 2026

Copy link
Copy Markdown
Collaborator

Flakey Tests

🤖 says: This CI run detected 1 tests that failed, but were tolerated due to a .test_patterns.yml entry.

\033FLAKED\033 (8;;http://ci.aztec-labs.com/88a47d500102f2c2�88a47d500102f2c28;;�):  yarn-project/end-to-end/scripts/run_test.sh simple src/e2e_epochs/epochs_missed_l1_publish.test.ts (153s) (code: 0) group:e2e-p2p-epoch-flakes

@nchamo nchamo marked this pull request as ready for review May 9, 2026 21:50
@nchamo nchamo requested a review from benesjan May 9, 2026 23:47
@nchamo nchamo merged commit c3cfd3d into merge-train/fairies May 11, 2026
31 of 37 checks passed
@nchamo nchamo deleted the nchamo/perf-batch-read-request-verification branch May 11, 2026 11:36
@AztecBot

Copy link
Copy Markdown
Collaborator

✅ Successfully backported to backport-to-v4-next-staging #23142.

benesjan added a commit that referenced this pull request May 12, 2026
BEGIN_COMMIT_OVERRIDE
fix(sequencer): bounded sweep instead of event scan for governance
proposal check (#22989)
fix(sequencer): bounded sweep instead of event scan for governance
proposal check (#22989) (#23001)
chore: route backport CI failure notifications to #backports channel
(#21779)
fix: (A-589) epochs l1 reorgs test (#20999)
chore: Accumulated backports to v4 (#23065)
fix(bb-prover): use temp directory for avm_verify (#23138)
chore: notify on v4-next sync (#23139)
refactor(pxe): use findLeavesIndexes for read request verification
(#23123)
refactor(pxe): skip storage reads for never-updated contracts (#23131)
fix(pxe): skip registerContractFunctionSignatures when no public fns
(#23134)
chore: Update Noir to nightly-2026-04-15 (#22572)
chore: Update Noir to nightly-2026-04-16 (#22594)
chore: Update Noir to nightly-2026-04-17 (#22633)
chore: Update Noir to nightly-2026-04-23 (#22653)
chore: Update Noir to nightly-2026-04-28 (#22755)
chore: Update Noir to nightly-2026-05-01 (#22836)
chore: Update Noir to nightly-2026-05-05 (#22911)
chore: Update Noir to nightly-2026-05-11 (#23023)
chore: backport noir sync PRs to backport-to-v4-next-staging (#23148)
refactor(pxe): prefetch updated class id hints per unique contract
(#23130)
chore(aztec-nr): Public self constructor function to prevent static byte
code size blow up (#23062)
chore: merge v4 into backport-to-v4-next-staging (#23140)
chore(aztec-nr): Public self constructor function (backport #23062)
(#23156)
refactor(pxe): avoid expensive toTx() call when computing tx hash
(#23136)
END_COMMIT_OVERRIDE
rangozd pushed a commit to rangozd/aztec-packages that referenced this pull request May 16, 2026
BEGIN_COMMIT_OVERRIDE
refactor(pxe): use findLeavesIndexes for read request verification
(AztecProtocol#23123)
refactor(pxe): skip storage reads for never-updated contracts (AztecProtocol#23131)
fix(pxe): skip registerContractFunctionSignatures when no public fns
(AztecProtocol#23134)
refactor(pxe): prefetch updated class id hints per unique contract
(AztecProtocol#23130)
chore(aztec-nr): Public self constructor function to prevent static byte
code size blow up (AztecProtocol#23062)
refactor(pxe): avoid expensive toTx() call when computing tx hash
(AztecProtocol#23136)
END_COMMIT_OVERRIDE
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-to-v4-next ci-draft Run CI on draft PRs. ci-no-fail-fast Sets NO_FAIL_FAST in the CI so the run is not aborted on the first failure

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants