Skip to content

fix(bb-prover): use temp directory for avm_verify#23138

Merged
fcarreiro merged 1 commit into
v4from
fc/avm-verify-working-dir
May 11, 2026
Merged

fix(bb-prover): use temp directory for avm_verify#23138
fcarreiro merged 1 commit into
v4from
fc/avm-verify-working-dir

Conversation

@fcarreiro

@fcarreiro fcarreiro commented May 11, 2026

Copy link
Copy Markdown
Contributor

verifyAvmProof(from execute.ts) was using the shared this.config.bbWorkingDirectorypath to write the avm_inputs.bin file. Under concurrent operations, the files could get overwritten and verification would fail.

This PR plumbs the temporary path so that it gets used.

@fcarreiro fcarreiro requested a review from a team May 11, 2026 09:11

Copy link
Copy Markdown
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@fcarreiro fcarreiro force-pushed the fc/avm-verify-working-dir branch from fc5e64a to 5884762 Compare May 11, 2026 09:18

fcarreiro commented May 11, 2026

Copy link
Copy Markdown
Contributor Author

Merge activity

  • May 11, 9:43 AM UTC: A user started a stack merge that includes this pull request via Graphite.
  • May 11, 9:44 AM UTC: Graphite rebased this pull request as part of a merge.
  • May 11, 10:04 AM UTC: Graphite couldn't merge this PR because it failed for an unknown reason (Squash merges are not allowed on this repository. Please update the merge method in your Graphite merge queue settings, or enable squash merging in your GitHub repository settings.).

@fcarreiro fcarreiro force-pushed the fc/avm-verify-working-dir branch from 5884762 to 0d6a0c7 Compare May 11, 2026 09:44
@fcarreiro fcarreiro merged commit da61170 into v4 May 11, 2026
10 checks passed
@fcarreiro fcarreiro deleted the fc/avm-verify-working-dir branch May 11, 2026 10:31
benesjan added a commit that referenced this pull request May 12, 2026
BEGIN_COMMIT_OVERRIDE
fix(sequencer): bounded sweep instead of event scan for governance
proposal check (#22989)
fix(sequencer): bounded sweep instead of event scan for governance
proposal check (#22989) (#23001)
chore: route backport CI failure notifications to #backports channel
(#21779)
fix: (A-589) epochs l1 reorgs test (#20999)
chore: Accumulated backports to v4 (#23065)
fix(bb-prover): use temp directory for avm_verify (#23138)
chore: notify on v4-next sync (#23139)
refactor(pxe): use findLeavesIndexes for read request verification
(#23123)
refactor(pxe): skip storage reads for never-updated contracts (#23131)
fix(pxe): skip registerContractFunctionSignatures when no public fns
(#23134)
chore: Update Noir to nightly-2026-04-15 (#22572)
chore: Update Noir to nightly-2026-04-16 (#22594)
chore: Update Noir to nightly-2026-04-17 (#22633)
chore: Update Noir to nightly-2026-04-23 (#22653)
chore: Update Noir to nightly-2026-04-28 (#22755)
chore: Update Noir to nightly-2026-05-01 (#22836)
chore: Update Noir to nightly-2026-05-05 (#22911)
chore: Update Noir to nightly-2026-05-11 (#23023)
chore: backport noir sync PRs to backport-to-v4-next-staging (#23148)
refactor(pxe): prefetch updated class id hints per unique contract
(#23130)
chore(aztec-nr): Public self constructor function to prevent static byte
code size blow up (#23062)
chore: merge v4 into backport-to-v4-next-staging (#23140)
chore(aztec-nr): Public self constructor function (backport #23062)
(#23156)
refactor(pxe): avoid expensive toTx() call when computing tx hash
(#23136)
END_COMMIT_OVERRIDE
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants