fix(txe): correct TXE_ORACLE_INTERFACE_HASH to match current oracle interface#23460
Merged
Conversation
Collaborator
Author
Flakey Tests🤖 says: This CI run detected 1 tests that failed, but were tolerated due to a .test_patterns.yml entry. |
nchamo
approved these changes
May 21, 2026
github-merge-queue Bot
pushed a commit
that referenced
this pull request
May 25, 2026
BEGIN_COMMIT_OVERRIDE feat(txe): add TXE oracle version check to bootstrap (#23324) fix(txe): correct TXE_ORACLE_INTERFACE_HASH to match current oracle interface (#23460) feat(aztec-nr): add Serialize/Deserialize for EphemeralArray (#23417) refactor: move validation and error handling out of transport layer (#23422) feat(pxe)!: add source and block-range filtering to get_logs_by_tag (#23326) fix(txe): update TXE oracle interface hash for new AVM oracle methods (#23492) chore(ci): capture sandbox diagnostics on acceptance test failure (#23495) feat(aztec-nr)!: rename push_nullifier to push_nullifier_unsafe (#23488) feat(aztec-nr)!: add explicit custom_sync_state hook to AztecConfig (#23446) fix(ci): skip aztec-cli notify job when acceptance test is skipped (#23534) fix: released contract artifact aztec version (forward port of #23470) (#23500) fix: merge train conflicts (#23548) END_COMMIT_OVERRIDE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The merge-train/fairies build failed in
yarn-project→compile_all(ci.aztec-labs.com/3b9623ba54db88b4), on the new TXE oracle version check added by #23324:The check is correct; the pinned literal is wrong. #23324 committed
TXE_ORACLE_INTERFACE_HASH = '6ab5922a…', which corresponds to the TXE oracle interface before #23289 ("feat: add basic gas settings to testenv") added agasSettings: GasSettingsparameter to twoITxeExecutionOraclemethods. #23289 has been onnextfor a week, sointerfaces.tsalready carriesgasSettingsand the live interface hashes toc5e3567b…. The literal was computed against a stale base.Fix
Re-pin
TXE_ORACLE_INTERFACE_HASHto the value the check computes against the current interface (c5e3567b…), which is exactly what the failing build emitted.No version bump: #23289's
gasSettingsalready shipped under TXE oracle version 1.0.0, and both the TS (txe_oracle_version.ts) and Noir (txe_oracles.nr) sides are at MAJOR=1/MINOR=0 with matching signatures. This pins the baseline hash to the current interface rather than recording a new interface change on top of an already-correct baseline.The train re-run validates the value end-to-end.
Created by claudebox · group:
slackbot