feat(pxe)!: allow apps to inject tagging secrets into getPendingTaggedLogs#23777
Merged
Merged
Conversation
nchamo
commented
Jun 1, 2026
vezenovm
approved these changes
Jun 3, 2026
…/get-tagged-logs-improvement # Conflicts: # noir-projects/aztec-nr/aztec/src/standard_addresses.nr # noir-projects/noir-contracts/contracts/protocol/aztec_sublib/src/standard_addresses.nr # noir-projects/noir-contracts/pinned-standard-contracts.tar.gz # yarn-project/pxe/src/contract_function_simulator/index.ts # yarn-project/pxe/src/contract_function_simulator/oracle/oracle_registry.ts # yarn-project/standard-contracts/src/standard_contract_data.ts # yarn-project/txe/src/rpc_translator.ts
danielntmd
pushed a commit
to danielntmd/aztec-packages
that referenced
this pull request
Jun 4, 2026
BEGIN_COMMIT_OVERRIDE chore: document browser kv-store backend migration (AztecProtocol#23779) feat(aztec-nr): Compute unconstrained tag in Noir over PXE and generalize get_next_tagging_index oracle (AztecProtocol#23796) refactor(txe): migrate rpc_translator to typed oracle registry (AztecProtocol#23530) feat(pxe)!: allow apps to inject tagging secrets into getPendingTaggedLogs (AztecProtocol#23777) feat(txe): add oracle roundtrip test framework (AztecProtocol#23537) fix: embedded wallet defaults to proposed (AztecProtocol#23819) feat(aztec-nr): discover non-interactive handshakes in the registry (AztecProtocol#23806) refactor(txe): normalize deploy and addAccount to oracle registry (AztecProtocol#23536) fix: wait for checkpoint during sandbox setup (AztecProtocol#23834) feat(standard-contracts): graduate handshake registry to standard contract (AztecProtocol#23833) END_COMMIT_OVERRIDE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why we are doing this
The private-message tagging system needs to support handshake-derived secrets, which PXE cannot enumerate on its own. Today
get_pending_tagged_logsonly searches secrets PXE derives internally from registered senders and local accounts.Our fix
Adds a
provided_secrets: EphemeralArray<ProvidedSecret>parameter to theaztec_utl_getPendingTaggedLogsoracle. EachProvidedSecretcarries a raw secret and amode(unconstrained or constrained). Provided secrets are merged with PXE-derived secrets and fed into the existing windowed scan — no new search logic required.Fixes F-658