fix: embedded wallet defaults to proposed#23819
Merged
Merged
Conversation
Thunkar
changed the title
AztecBot
pushed a commit
that referenced
this pull request
Jun 3, 2026
This was broken in the default case, because we were relying on mutation `opts.wait` that is usually undefined. Hopefully the code is a bit clearer too
Collaborator
|
✅ Successfully backported to backport-to-v5-next-staging #23832. |
AztecBot
added a commit
that referenced
this pull request
Jun 3, 2026
The real source of flakiness was the local network setup (createLocalNetwork), fixed by waiting for the checkpoint there. The CHECKPOINTED waits added to the react/vite/vanilla boxes in #23819 did not help, so revert them and let the box sends use the embedded wallet PROPOSED default.
Thunkar
pushed a commit
that referenced
this pull request
Jun 3, 2026
## Problem CI on `merge-train/fairies` failed on the boxes `react chromium` test ([log](http://ci.aztec-labs.com/1780510430908759), [failing test](http://ci.aztec-labs.com/243e7294cb8ba269)) with a timeout (code 124). The actual error was during `aztec start` / `createLocalNetwork`: ``` Error: Transaction 0x0826… was dropped. Reason: Tx dropped by P2P node at NodeEmbeddedWallet.sendTx at DeployAccountMethod.send at deployFundedSchnorrAccounts at createLocalNetwork at aztecStart ``` The local network never came up, so the browser test timed out. ## Root cause PR #23819 ("embedded wallet defaults to proposed") fixed the embedded wallet so its default wait status is *actually* `PROPOSED` — previously the default was a no-op that fell through to `waitForTx`'s `CHECKPOINTED` default. `PROPOSED` returns as soon as a tx lands in a proposed L2 block. In the serial sandbox setup that races against block pruning: a proposed-but-not-checkpointed block can be pruned by end of build slot (see #23606), and a tx in it is then neither in the archiver nor the pool, so `getTxReceipt` returns `DroppedTxReceipt("Tx dropped by P2P node")`. With the old broken default this path waited for `CHECKPOINTED` and was reliable. The real source of flakiness is the local network setup, not the boxes. ## Fix Thread an explicit `{ waitForStatus: TxStatus.CHECKPOINTED }` wait through the sandbox-setup sends: - `createLocalNetwork`: `deployFundedSchnorrAccounts`, `publishStandardAuthRegistry`, `setupBananaFPC` - `setup-l2-contracts` CLI wait options The intended product default of `PROPOSED` for normal wallet usage is unchanged; only the CI/sandbox bring-up that needs durable inclusion before the next serial tx is pinned to `CHECKPOINTED`. e2e fixtures use `TestWallet` (BaseWallet's `CHECKPOINTED` default) and are unaffected. Also reverts the per-box `CHECKPOINTED` waits that #23819 added to the react/vite/vanilla boxes: they didn't fix the flakiness (the local-network setup did), so the box sends go back to using the embedded wallet `PROPOSED` default. ## Verification TypeScript-only change in `yarn-project` plus box reverts; the box files now match their pre-#23819 state exactly. A full `./bootstrap.sh ci` could not be run in this container (clang 18 vs required 20, zig missing, no remote build cache; the suite is multi-hour). Confirmed by the merge-train CI re-run of the boxes tests.
AztecBot
added a commit
that referenced
this pull request
Jun 4, 2026
BEGIN_COMMIT_OVERRIDE fix: embedded wallet defaults to proposed (#23819) END_COMMIT_OVERRIDE
danielntmd
pushed a commit
to danielntmd/aztec-packages
that referenced
this pull request
Jun 4, 2026
BEGIN_COMMIT_OVERRIDE chore: document browser kv-store backend migration (AztecProtocol#23779) feat(aztec-nr): Compute unconstrained tag in Noir over PXE and generalize get_next_tagging_index oracle (AztecProtocol#23796) refactor(txe): migrate rpc_translator to typed oracle registry (AztecProtocol#23530) feat(pxe)!: allow apps to inject tagging secrets into getPendingTaggedLogs (AztecProtocol#23777) feat(txe): add oracle roundtrip test framework (AztecProtocol#23537) fix: embedded wallet defaults to proposed (AztecProtocol#23819) feat(aztec-nr): discover non-interactive handshakes in the registry (AztecProtocol#23806) refactor(txe): normalize deploy and addAccount to oracle registry (AztecProtocol#23536) fix: wait for checkpoint during sandbox setup (AztecProtocol#23834) feat(standard-contracts): graduate handshake registry to standard contract (AztecProtocol#23833) END_COMMIT_OVERRIDE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was broken in the default case, because we were relying on mutating
opts.waitthat is usually undefined.Hopefully the code is a bit clearer too