refactor(pxe)!: derive oracle interfaces from registry and introduce aztec_misc_ prefix#23840
Merged
Merged
Conversation
nchamo
commented
Jun 3, 2026
| /** | ||
| * Information about a note needed during execution. | ||
| */ | ||
| export interface NoteData { |
Contributor
Author
There was a problem hiding this comment.
Moved this from interfaces.ts to its own file
nchamo
requested review from
IlyasRidhuan,
LeilaWang,
MirandaWood,
jeanmon,
nventuro and
sirasistant
as code owners
nchamo
changed the title
Thunkar
approved these changes
Jun 4, 2026
…/oracle-hash-calculation # Conflicts: # noir-projects/noir-contracts/pinned-standard-contracts.tar.gz
Collaborator
Flakey Tests🤖 says: This CI run detected 2 tests that failed, but were tolerated due to a .test_patterns.yml entry. |
This was referenced Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why we are doing this
Oracle handler interfaces (
IUtilityExecutionOracle,IPrivateExecutionOracle) were hand-written and had to be kept in sync withORACLE_REGISTRYentries manually. Three cross-cutting oracles (log,getRandomField,assertCompatibleOracleVersion) were incorrectly scoped underaztec_utl_despite being available in all execution contexts.Our fix
IUtilityExecutionOracleandIPrivateExecutionOraclefromORACLE_REGISTRYusing TypeScript mapped types (HandlersForPrefix). Adding a new oracle entry to the registry now automatically updates the handler interface.aztec_misc_prefix for the 3 cross-cutting oracles and deriveIMiscOraclefrom it.NoteDatafrominterfaces.tstonoir-structs/note_data.ts.Note
I haven't tackled this same refactor for TXE yet, since we need to do more clean up before we get to it