chore(ci): public nightlies skip scenario tests and the next tag#23984
Merged
Conversation
AztecBot
added
ci-draft
alexghr
approved these changes
Jun 10, 2026
alexghr
approved these changes
Jun 11, 2026
AztecBot
force-pushed
the
cb/public-nightly-no-scenario-no-next-tag
branch
from
63540bc to
be3cc49
Compare
## What Two changes scoped to the **public** repo (`AztecProtocol/aztec-packages`) nightly flow, plus a follow-up tightening of the scenario-test trigger. Private tagging is unchanged. ### 1. Network scenario tests run only on the private v5-next nightly `ci3.yml`'s `ci-network-scenario` job fired on any current nightly tag in both repos. Private produces both a `next` (v6) and a `v5-next` (v5) nightly tag, so simply gating to the private repo still ran scenarios against the v6 nightly. The nightly-triggered path is now gated to **private repo + a `v5.` nightly tag**: ```yaml ( needs.validate-nightly-tag.outputs.is_current == 'true' && github.repository == 'AztecProtocol/aztec-packages-private' && startsWith(github.ref_name, 'v5.') ) || contains(github.event.pull_request.labels.*.name, 'ci-network-scenario') ``` `v5-next` is at `5.x.x` (tag `v5.x.x-nightly.*`) and `next` is at `6.x.x` (tag `v6.x.x-nightly.*`), so `startsWith(github.ref_name, 'v5.')` selects the v5-next nightly only. The manual PR-label path (`ci-network-scenario`) is preserved for ad-hoc dev runs. ### 2. Stop tagging `next` with a nightly tag in public `nightly-release-tag.yml`'s matrix tagged `[next, v5-next]` in both repos. The branch list is now repo-dependent: private keeps `[next, v5-next]`, public tags only `v5-next` (and `v4-next` via its existing dedicated job). Net result: **public tags `v4-next` + `v5-next` only**, private is untouched. ## Why Nightly network scenario tests should run only against the private v5-next nightly, and public should not produce a `next` nightly tag.
AztecBot
force-pushed
the
cb/public-nightly-no-scenario-no-next-tag
branch
from
be3cc49 to
56168b3
Compare
Collaborator
Author
Flakey Tests🤖 says: This CI run detected 1 tests that failed, but were tolerated due to a .test_patterns.yml entry. |
Collaborator
Author
|
❌ Failed to cherry-pick to |
alexghr
added a commit
that referenced
this pull request
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Two changes scoped to the public repo (
AztecProtocol/aztec-packages) nightly flow, plus a follow-up tightening of the scenario-test trigger. Private tagging is unchanged.1. Network scenario tests run only on the private v5-next nightly
ci3.yml'sci-network-scenariojob fired on any current nightly tag in both repos. Private produces both anext(v6) and av5-next(v5) nightly tag, so simply gating to the private repo still ran scenarios against the v6 nightly. The nightly-triggered path is now gated to private repo + av5.nightly tag:v5-nextis at5.x.x(tagv5.x.x-nightly.*) andnextis at6.x.x(tagv6.x.x-nightly.*), sostartsWith(github.ref_name, 'v5.')selects the v5-next nightly only. The manual PR-label path (ci-network-scenario) is preserved for ad-hoc dev runs.2. Stop tagging
nextwith a nightly tag in publicnightly-release-tag.yml's matrix tagged[next, v5-next]in both repos. The branch list is now repo-dependent: private keeps[next, v5-next], public tags onlyv5-next(andv4-nextvia its existing dedicated job). Net result: public tagsv4-next+v5-nextonly, private is untouched.Why
Nightly network scenario tests should run only against the private v5-next nightly, and public should not produce a
nextnightly tag.