Skip to content

chore(ci): public nightlies skip scenario tests and the next tag (backport #23984)#24009

Merged
alexghr merged 1 commit into
backport-to-v5-next-stagingfrom
cb/backport-23984-v5-next
Jun 11, 2026
Merged

chore(ci): public nightlies skip scenario tests and the next tag (backport #23984)#24009
alexghr merged 1 commit into
backport-to-v5-next-stagingfrom
cb/backport-23984-v5-next

Conversation

@AztecBot

@AztecBot AztecBot commented Jun 11, 2026

Copy link
Copy Markdown
Collaborator

Summary

Backport of #23984 to v5-next (via the backport-to-v5-next-staging staging branch), plus removal of the now-duplicate v5-next nightly tag workflow.

Changes

1. ci3.yml — gate ci-network-scenario to the private v5-next nightly (clean merge):
The nightly-triggered ci-network-scenario job now requires the private repo and a v5. nightly tag, so it no longer fires against the v6 (next) nightly. The ci-network-scenario PR-label path is preserved.

2. Remove nightly-release-tag.yml on v5-next — tag from a single place:
After #23984, the private repo's nightly-release-tag matrix tags both next and v5-next, so the v5-next branch's own nightly-tag workflow produced a duplicate v5-next nightly tag. Removed it so all nightly tagging happens in one place (the private repo matrix).

Conflict resolution

PR #23984's nightly-release-tag.yml change conflicted because v5-next's copy of that workflow had no branch: [next, v5-next] matrix. Rather than adapt the matrix rewrite, the whole workflow is removed on v5-next (see change 2), which is the cleaner outcome.

)

Two changes scoped to the **public** repo
(`AztecProtocol/aztec-packages`) nightly flow, plus a follow-up
tightening of the scenario-test trigger. Private tagging is unchanged.

`ci3.yml`'s `ci-network-scenario` job fired on any current nightly tag
in both repos. Private produces both a `next` (v6) and a `v5-next` (v5)
nightly tag, so simply gating to the private repo still ran scenarios
against the v6 nightly. The nightly-triggered path is now gated to
**private repo + a `v5.` nightly tag**:

```yaml
(
  needs.validate-nightly-tag.outputs.is_current == 'true'
  && github.repository == 'AztecProtocol/aztec-packages-private'
  && startsWith(github.ref_name, 'v5.')
)
|| contains(github.event.pull_request.labels.*.name, 'ci-network-scenario')
```

`v5-next` is at `5.x.x` (tag `v5.x.x-nightly.*`) and `next` is at
`6.x.x` (tag `v6.x.x-nightly.*`), so `startsWith(github.ref_name,
'v5.')` selects the v5-next nightly only. The manual PR-label path
(`ci-network-scenario`) is preserved for ad-hoc dev runs.

`nightly-release-tag.yml`'s matrix tagged `[next, v5-next]` in both
repos. The branch list is now repo-dependent: private keeps `[next,
v5-next]`, public tags only `v5-next` (and `v4-next` via its existing
dedicated job). Net result: **public tags `v4-next` + `v5-next` only**,
private is untouched.

Nightly network scenario tests should run only against the private
v5-next nightly, and public should not produce a `next` nightly tag.
@AztecBot AztecBot added ci-draft Run CI on draft PRs. ci-no-fail-fast Sets NO_FAIL_FAST in the CI so the run is not aborted on the first failure claudebox Owned by claudebox. it can push to this PR. labels Jun 11, 2026
@alexghr alexghr force-pushed the cb/backport-23984-v5-next branch from 85e68f6 to 7576cbd Compare June 11, 2026 09:00
@alexghr alexghr marked this pull request as ready for review June 11, 2026 09:01
@alexghr alexghr requested a review from charlielye as a code owner June 11, 2026 09:01
@alexghr alexghr enabled auto-merge June 11, 2026 09:01
@alexghr alexghr merged commit 8ff6a85 into backport-to-v5-next-staging Jun 11, 2026
52 of 64 checks passed
@alexghr alexghr deleted the cb/backport-23984-v5-next branch June 11, 2026 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-draft Run CI on draft PRs. ci-no-fail-fast Sets NO_FAIL_FAST in the CI so the run is not aborted on the first failure ci-skip claudebox Owned by claudebox. it can push to this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants