fix: redo nullifier tree insertion algorithm#240
Merged
Conversation
Maddiaa0
force-pushed
the
md/new-nt-insertion-algo
branch
from
805c75e to
47f47b7
Compare
Member
Author
|
depends on this pr AztecProtocol/aztec3-circuits#231 |
fix: harden circuits
Collaborator
|
Looks like you're getting some of the issues I was trying to tackle here #216 |
PhilWindle
previously requested changes
Apr 14, 2023
| * @param leaves Values to insert into the tree | ||
| * @returns | ||
| */ | ||
| public async performBaseRollupBatchInsertionProofs(leaves: Buffer[]): Promise<LowNullifierWitnessData[] | undefined> { |
Collaborator
There was a problem hiding this comment.
I feel like we should break this function out into a seperate file, inject the db instance and create some test cases for it.
Contributor
There was a problem hiding this comment.
+1, but I think it's part of a bigger refactor on the block builder. I can take it once this is merged.
6 tasks
spalladino
approved these changes
Apr 14, 2023
spalladino
left a comment
spalladino
left a comment
Contributor
There was a problem hiding this comment.
LGTM, though I didn't go in depth on the workings of the algorithm itself, so take this approval with a grain of salt.
* add config from env vars in projects + update e2e config * remove comment * Fix automatic import * remove comments * remove hardcoded addresses + reduce .isMined poll freq * more chagnes to isMined freq * fix zero EthAddress
Maddiaa0
force-pushed
the
md/new-nt-insertion-algo
branch
from
aa14bd5 to
b95e098
Compare
6 tasks
Maddiaa0
dismissed
PhilWindle’s stale review
Changes will be addressed as part of a wider refactor
dbanks12
reviewed
Apr 14, 2023
| * val 0 5 10 15 2 3 20 19 | ||
| * nextIdx 5 2 3 8 6 2 0 7 | ||
| * nextVal 2 10 15 19 3 5 0 20 | ||
| * |
ludamad
pushed a commit
that referenced
this pull request
Jul 14, 2023
codygunton
pushed a commit
that referenced
this pull request
Jan 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes batch insertion algorithm that did not handle random test cases well enough. This pr covers most cases but further investigation is being done and more test cases written to harden the implementation
Checklist: