fix(ci): raise AVM check-circuit per-tx timeout from 30s to 120s#24043
Draft
AztecBot wants to merge 1 commit into
Draft
fix(ci): raise AVM check-circuit per-tx timeout from 30s to 120s#24043AztecBot wants to merge 1 commit into
AztecBot wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The nightly AVM Circuit Inputs Collection and Check workflow failed on
next(run 27394504089). The GitHub jobavm-check-circuitexited with code 124 (the SSM command surfaced the remotetimeoutexit code), andparallelize --halt now,fail=1aborted the whole job on the first failing command.Root cause
A single check-circuit command timed out — not a correctness failure:
That tx produces a large AVM circuit. From its log:
With the default ISOLATE resources (2 CPUs), trace generation (~19s) plus the check pass over ~700k rows exceeds the per-command
TIMEOUT=30s, sotimeoutkills it. That 30s value has been in place unchanged since the feature was added (#18747) and was never tuned; the inline comment already anticipated exactly this ("transactions could need more CPU and MEM than we allocate by default ... they might start timing out").Fix
Raise the per-command timeout from
30sto120sinavm_check_circuit_cmds. The heaviest observed tx needs ~40s end-to-end at 2 CPUs, so 120s gives comfortable margin as circuits grow while staying under the 5-minute "test too slow" warning threshold.CPUS is intentionally left at the default 2:
parallelizerunsnum_cpus/2jobs (96 on the 192-core CI box), so 2 CPUs per command already fully utilizes the machine. Bumping CPUS without changing the job count would oversubscribe the cores and get throttled back by CFS, providing no real speedup — a timeout bump is the correct, scheduler-consistent fix.Testing
Scripted change to a nightly CI path; behavior can't be exercised in unit CI. The fix is a timeout increase only — the circuit itself passed its checks up to the kill point, it simply needed more wall time than the old budget allowed.
Created by claudebox · group:
slackbot