fix: Flaky deployment test

[spalladino]

The test 'should not deploy a contract which failed the public part of the execution' depended on having a good and a bad tx. But the bad tx accidentally dependend on the good one, since it required the good one to register the class. If the txs were accidentally run out of order, the bad tx would fail earlier than we needed. So this fix ensures there's no dependency between the two.

[AztecBot]

Benchmark results

Metrics with a significant change:

• note_history_successful_decrypting_time_in_ms (5): 1,666 (+35%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit f6f34b7c and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	8 txs	32 txs	64 txs
l1_rollup_calldata_size_in_bytes	5,700	18,884	36,452
l1_rollup_calldata_gas	66,468	239,420	470,156
l1_rollup_execution_gas	194,416	500,726	909,414
l2_block_processing_time_in_ms	1,181 (-1%)	4,505 (+1%)	8,966 (+1%)
note_successful_decrypting_time_in_ms	200	543 (+1%)	1,015 (+4%)
note_trial_decrypting_time_in_ms	7.91 (-1%)	67.8 (+15%)	34.8 (-69%)
l2_block_building_time_in_ms	11,233	44,783	89,880 (+1%)
l2_block_rollup_simulation_time_in_ms	7,307	29,284	58,784 (+1%)
l2_block_public_tx_process_time_in_ms	3,893 (-1%)	15,436	30,975 (+1%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric	5 blocks	10 blocks
node_history_sync_time_in_ms	15,823 (+8%)	27,730 (-1%)
note_history_successful_decrypting_time_in_ms	⚠️ 1,666 (+35%)	2,424 (+2%)
note_history_trial_decrypting_time_in_ms	138 (+66%)	138 (+21%)
node_database_size_in_bytes	18,780,240	35,541,072
pxe_database_size_in_bytes	29,923	59,478

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit	circuit_simulation_time_in_ms	circuit_input_size_in_bytes	circuit_output_size_in_bytes
private-kernel-init	257 (+2%)	44,736	28,001
private-kernel-ordering	198 (+2%)	52,625	14,627
base-rollup	657	177,932	997
root-rollup	68.9	4,320	825
private-kernel-inner	323 (+1%)	73,715	28,001
public-kernel-app-logic	174 (+2%)	32,254	25,379
merge-rollup	8.61 (+1%)	2,840	997

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	2 leaves	8 leaves	16 leaves	32 leaves	64 leaves	128 leaves	512 leaves	1024 leaves	2048 leaves	4096 leaves
batch_insert_into_append_only_tree_16_depth_ms	9.88 (+1%)	10.5 (-6%)	13.8 (-7%)	16.5 (+1%)	22.1 (+1%)	35.3	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.9	17.5	23.0	31.6	47.0	79.0	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.573 (+1%)	0.584 (-6%)	0.588 (-7%)	0.510 (+1%)	0.464 (+1%)	0.440	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	N/A	N/A	N/A	46.8 (+2%)	72.0	230	449 (+1%)	868	1,726
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	N/A	N/A	N/A	96.0	159	543	1,055	2,079	4,127
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	N/A	N/A	N/A	0.480 (+2%)	0.444 (-1%)	0.419 (-1%)	0.420 (+1%)	0.412 (-1%)	0.413
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	N/A	N/A	N/A	53.8 (+1%)	107 (+1%)	338	667 (+1%)	1,310	2,612
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	N/A	N/A	N/A	104	207	691	1,363	2,707	5,395
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	N/A	N/A	N/A	0.479	0.482 (+1%)	0.461 (+1%)	0.459 (+1%)	0.456	0.453
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	N/A	N/A	61.6 (+1%)	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	N/A	N/A	109	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	N/A	N/A	0.539 (+1%)	N/A	N/A	N/A	N/A	N/A	N/A

Miscellaneous

Transaction sizes based on how many contracts are deployed in the tx.

Metric	0 deployed contracts
tx_size_in_bytes	19,179

Transaction processing duration by data writes.

Metric	0 new note hashes	1 new note hashes
tx_pxe_processing_time_ms	2,714 (+1%)	1,390 (+1%)

Metric	0 public data writes	1 public data writes
tx_sequencer_processing_time_ms	0.0320 (+17%)	482 (+2%)