Skip to content

fix: Flaky deployment test #5035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
spalladino merged 1 commit into from
Mar 7, 2024
Merged

fix: Flaky deployment test #5035

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 5 additions & 16 deletions yarn-project/end-to-end/src/e2e_deploy_contract.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,23 +123,17 @@ describe('e2e_deploy_contract', () => {
);
}, 60_000);

// TODO(@spalladino): Review this test, it's showing an unexpected 'Bytecode not found' error in logs.
// It's possible it is failing for the wrong reason, and the getContractData checks are returning wrong data.
it('should not deploy a contract which failed the public part of the execution', async () => {
sequencer?.updateSequencerConfig({
minTxsPerBlock: 2,
});

sequencer?.updateSequencerConfig({ minTxsPerBlock: 2 });
try {
// This test requires at least another good transaction to go through in the same block as the bad one.
// I deployed the same contract again but it could really be any valid transaction here.
const artifact = TokenContractArtifact;
const initArgs = ['TokenName', 'TKN', 18] as const;
const goodDeploy = new ContractDeployer(artifact, wallet).deploy(AztecAddress.random(), ...initArgs);
const goodDeploy = StatefulTestContract.deploy(wallet, accounts[0], 42);
const badDeploy = new ContractDeployer(artifact, wallet).deploy(AztecAddress.ZERO, ...initArgs);

const firstOpts = { skipPublicSimulation: true };
const secondOpts = { skipPublicSimulation: true, skipClassRegistration: true };
const firstOpts = { skipPublicSimulation: true, skipClassRegistration: true, skipInstanceDeploy: true };
const secondOpts = { skipPublicSimulation: true };

await Promise.all([goodDeploy.simulate(firstOpts), badDeploy.simulate(secondOpts)]);
const [goodTx, badTx] = [goodDeploy.send(firstOpts), badDeploy.send(secondOpts)];
Expand All @@ -153,15 +147,10 @@ describe('e2e_deploy_contract', () => {
expect(goodTxReceipt.blockNumber).toEqual(expect.any(Number));
expect(badTxReceipt.blockNumber).toBeUndefined();

await expect(pxe.getContractData(goodDeploy.getInstance().address)).resolves.toBeDefined();
await expect(pxe.getExtendedContractData(goodDeploy.getInstance().address)).resolves.toBeDefined();

await expect(pxe.getContractData(badDeploy.getInstance().address)).resolves.toBeUndefined();
await expect(pxe.getExtendedContractData(badDeploy.getInstance().address)).resolves.toBeUndefined();
} finally {
sequencer?.updateSequencerConfig({
minTxsPerBlock: 1,
});
sequencer?.updateSequencerConfig({ minTxsPerBlock: 1 });
}
}, 90_000);
});
Expand Down