Skip to content

feat: Sync from noir#5999

Merged
TomAFrench merged 5 commits into
masterfrom
sync-noir
Apr 24, 2024
Merged

feat: Sync from noir#5999
TomAFrench merged 5 commits into
masterfrom
sync-noir

Conversation

@AztecBot

Copy link
Copy Markdown
Collaborator

Automated pull of development from the noir programming language, a dependency of Aztec.
BEGIN_COMMIT_OVERRIDE
fix: fix curve parameters for bigints (noir-lang/noir#4900)
chore: bump rustls to v0.21.11 (noir-lang/noir#4895)
fix: Update noir-gates-diff commit to use master reference report (noir-lang/noir#4891)
fix: Reset the noir-gates-diff report on master (noir-lang/noir#4878)
fix(experimental): Skip over comptime functions in scan pass (noir-lang/noir#4893)
chore(experimental): Improve variable not defined error message in comptime interpreter (noir-lang/noir#4889)
chore(experimental): Add scan pass and into_expression for comptime interpreter (noir-lang/noir#4884)
END_COMMIT_OVERRIDE

chore: bump `rustls` to v0.21.11 (noir-lang/noir#4895)
fix: Update noir-gates-diff commit to use master reference report (noir-lang/noir#4891)
fix: Reset the noir-gates-diff report on master (noir-lang/noir#4878)
fix(experimental): Skip over comptime functions in scan pass (noir-lang/noir#4893)
chore(experimental): Improve variable not defined error message in comptime interpreter (noir-lang/noir#4889)
chore(experimental): Add scan pass and `into_expression` for comptime interpreter (noir-lang/noir#4884)
@TomAFrench TomAFrench force-pushed the sync-noir branch 2 times, most recently from d03ff9f to 06df3ad Compare April 24, 2024 13:36
* master: (102 commits)
  chore(ci): make syncing out to Noir manual (#5997)
  docs: update emit_event.md (#5964)
  chore: yarn build:dev don't clear terminal (#5970)
  fix: deploy L1 contracts before starting node (#5969)
  refactor: using poseidon2 when computing a nullifier (#5906)
  chore(ci): reenable spot
  git subrepo push --branch=master noir-projects/aztec-nr
  git_subrepo.sh: Fix parent in .gitrepo file. [skip ci]
  chore: replace relative paths to noir-protocol-circuits
  git subrepo push --branch=master barretenberg
  feat: Keshas skipping plus conditions for grand prod relations (#5766)
  feat!: delete field note (#5959)
  feat: Sync from noir (#5955)
  chore: Run flakey e2e tests on CI but allow failure (#5937)
  feat(avm): avm circuit FDIV opcode (#5958)
  feat!: remove slow updates tree (#5954)
  fix(avm): comments and assert (#5956)
  refactor: renaming `noir-compiler` as `builder` (#5951)
  feat(avm): negative tests (#5919)
  feat(avm): shift relations (#5716)
  ...
@TomAFrench TomAFrench enabled auto-merge (squash) April 24, 2024 13:59
@TomAFrench TomAFrench merged commit 2e64428 into master Apr 24, 2024
@TomAFrench TomAFrench deleted the sync-noir branch April 24, 2024 14:25
@AztecBot

Copy link
Copy Markdown
Collaborator Author

Benchmark results

Metrics with a significant change:

  • note_trial_decrypting_time_in_ms (64): 120 (+407%)
Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric 8 txs 32 txs 64 txs
l1_rollup_calldata_size_in_bytes 772 772 772
l1_rollup_calldata_gas 6,832 6,844 6,820
l1_rollup_execution_gas 587,313 587,325 587,301
l2_block_processing_time_in_ms 1,452 (-7%) 5,337 (-4%) 10,502
note_successful_decrypting_time_in_ms 248 540 (-11%) 1,121 (+2%)
note_trial_decrypting_time_in_ms 38.6 (-5%) 33.3 (-69%) ⚠️ 120 (+407%)
l2_block_building_time_in_ms 18,872 73,621 146,670 (+1%)
l2_block_rollup_simulation_time_in_ms 18,655 72,861 145,193 (+1%)
l2_block_public_tx_process_time_in_ms 8,558 (+1%) 33,433 (+1%) 66,958 (+1%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric 5 blocks 10 blocks
node_history_sync_time_in_ms 15,920 (-3%) 30,647 (+5%)
note_history_successful_decrypting_time_in_ms 1,298 (-9%) 2,680 (+4%)
note_history_trial_decrypting_time_in_ms 82.4 (-8%) 74.0 (-52%)
node_database_size_in_bytes 19,165,264 35,876,944
pxe_database_size_in_bytes 29,859 59,414

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit circuit_simulation_time_in_ms circuit_input_size_in_bytes circuit_output_size_in_bytes
private-kernel-init 156 (+1%) 47,763 31,978
private-kernel-inner 178 (+1%) 80,794 31,978
private-kernel-ordering 137 57,732 50,043
base-parity 74.2 128 265
root-parity 123 (+2%) 1,244 265
base-rollup 12,245 110,926 957
root-rollup 49.7 4,551 821
public-kernel-app-logic 1,656 62,017 52,067
public-kernel-tail 4,213 (+1%) 168,566 7,491
merge-rollup 3,118 2,760 957
public-kernel-teardown 112 (+1%) 62,017 52,067
public-kernel-setup 117 (-1%) 62,017 52,067

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric 1 leaves 16 leaves 64 leaves 128 leaves 512 leaves 1024 leaves 2048 leaves 4096 leaves 32 leaves
batch_insert_into_append_only_tree_16_depth_ms 11.0 (+1%) 17.6 N/A N/A N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_16_depth_hash_count 16.8 31.6 N/A N/A N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_16_depth_hash_ms 0.641 (+1%) 0.545 N/A N/A N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_32_depth_ms N/A N/A 51.5 (+1%) 80.3 259 500 (-1%) 983 (+1%) 1,951 (+1%) N/A
batch_insert_into_append_only_tree_32_depth_hash_count N/A N/A 96.0 159 543 1,055 2,079 4,127 N/A
batch_insert_into_append_only_tree_32_depth_hash_ms N/A N/A 0.528 (+1%) 0.495 0.472 0.467 (-1%) 0.467 (+1%) 0.467 (+1%) N/A
batch_insert_into_indexed_tree_20_depth_ms N/A N/A 60.3 119 (+1%) 377 (+1%) 737 1,471 2,932 (+1%) N/A
batch_insert_into_indexed_tree_20_depth_hash_count N/A N/A 105 207 691 1,363 2,707 5,395 N/A
batch_insert_into_indexed_tree_20_depth_hash_ms N/A N/A 0.532 0.538 (+1%) 0.515 (+1%) 0.507 0.510 (+1%) 0.512 (+1%) N/A
batch_insert_into_indexed_tree_40_depth_ms N/A N/A N/A N/A N/A N/A N/A N/A 67.6
batch_insert_into_indexed_tree_40_depth_hash_count N/A N/A N/A N/A N/A N/A N/A N/A 109
batch_insert_into_indexed_tree_40_depth_hash_ms N/A N/A N/A N/A N/A N/A N/A N/A 0.589

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric 0 registered classes 1 registered classes
tx_size_in_bytes 51,411 543,524

Transaction size based on fee payment method

Metric native fee payment method fpc_public fee payment method fpc_private fee payment method
tx_with_fee_size_in_bytes 897 1,145 1,345

Transaction processing duration by data writes.

Metric 0 new note hashes 1 new note hashes 2 new note hashes
tx_pxe_processing_time_ms 1,242 (+1%) 866 3,516 (+1%)
Metric 1 public data writes 2 public data writes 3 public data writes 4 public data writes 5 public data writes 8 public data writes
tx_sequencer_processing_time_ms 836 (+1%) 756 1,340 900 2,064 1,086

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants