fix: shared mutable private getter context fix - failing test mitigation

[sklppy88]

Mitigates failing state vars test

[sklppy88]

• fix: shared mutable private getter context fix - failing test mitigation #6653 👈
• fix: shared mutable private getter fixes #6652 : 1 other dependent PR (#6654 )
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @sklppy88 and the rest of your teammates on Graphite

[AztecBot]

Benchmark results

No metrics with a significant change found.

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Proof generation

Each column represents the number of threads used in proof generation.

Metric	1 threads	4 threads	16 threads	32 threads	64 threads
proof_construction_time_sha256	5,666 (-2%)	1,547	710	751 (-3%)	771

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	8 txs	32 txs	64 txs
l1_rollup_calldata_size_in_bytes	1,412	1,412	1,412
l1_rollup_calldata_gas	9,464	9,464	9,476
l1_rollup_execution_gas	616,105	616,105	616,117
l2_block_processing_time_in_ms	1,359 (-1%)	5,080 (-1%)	10,103
l2_block_building_time_in_ms	47,453 (+1%)	187,581 (+1%)	374,801 (+1%)
l2_block_rollup_simulation_time_in_ms	47,283 (+1%)	186,941 (+1%)	373,535 (+1%)
l2_block_public_tx_process_time_in_ms	25,714	106,668 (+2%)	218,121 (+2%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric	3 blocks	5 blocks
node_history_sync_time_in_ms	9,904 (-1%)	15,152
node_database_size_in_bytes	14,512,208	21,385,296
pxe_database_size_in_bytes	18,071	29,868

Circuits stats

Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.

Circuit	protocol_circuit_simulation_time_in_ms	protocol_circuit_witness_generation_time_in_ms	protocol_circuit_proving_time_in_ms	protocol_circuit_input_size_in_bytes	protocol_circuit_output_size_in_bytes	protocol_circuit_proof_size_in_bytes	protocol_circuit_num_public_inputs	protocol_circuit_size_in_gates
private-kernel-init	160 (+2%)	3,525 (+1%)	26,447 (+8%)	19,990	61,798	86,720	2,643	1,048,576
private-kernel-inner	604	4,029	53,042 (-4%)	88,862	61,798	86,720	2,643	2,097,152
private-kernel-tail	528	2,714 (+1%)	42,148 (-2%)	86,653	76,438	10,624	265	2,097,152
base-parity	6.47	1,228 (+2%)	2,906	128	64.0	2,208	2.00	131,072
root-parity	49.5 (+1%)	62.8 (-3%)	50,426 (-3%)	27,084	64.0	2,720	18.0	2,097,152
base-rollup	798 (+5%)	2,461 (+2%)	87,800 (-1%)	119,578	756	3,648	47.0	4,194,304
root-rollup	112	82.1 (+3%)	22,529 (-2%)	25,297	620	3,456	41.0	1,048,576
public-kernel-app-logic	527 (+1%)	2,899 (+2%)	52,192 (-2%)	103,405	84,766	116,832	3,584	2,097,152
public-kernel-tail	1,193 (+1%)	26,233 (-3%)	185,054	393,850	7,490	10,624	265	8,388,608
private-kernel-reset-small	577	2,059	28,321 (-7%)	118,173	61,798	86,720	2,643	1,048,576
merge-rollup	28.7 (-1%)	N/A	N/A	16,534	756	N/A	N/A	N/A
public-kernel-setup	622 (-2%)	N/A	N/A	103,405	84,766	N/A	N/A	N/A
public-kernel-teardown	527 (-2%)	N/A	N/A	103,405	84,766	N/A	N/A	N/A
private-kernel-tail-to-public	N/A	9,278 (+4%)	91,789 (-1%)	N/A	N/A	116,832	3,584	4,194,304

Stats on running time collected for app circuits

Function	app_circuit_proof_size_in_bytes	app_circuit_proving_time_in_ms	app_circuit_size_in_gates	app_circuit_num_public_inputs
SchnorrAccount:entrypoint	16,128	49,739 (-1%)	2,097,152	437
Token:transfer	16,128	47,980 (-1%)	2,097,152	437

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	16 leaves	64 leaves	128 leaves	512 leaves	1024 leaves	2048 leaves	4096 leaves	32 leaves
batch_insert_into_append_only_tree_16_depth_ms	11.0	18.0	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.7	31.8	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.640 (-1%)	0.552	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	52.1	80.8	262	505	984 (-1%)	1,952 (-1%)	N/A
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	95.9	159	543	1,055	2,079	4,127	N/A
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	0.532	0.498	0.476	0.471 (-1%)	0.467 (-1%)	0.466 (-1%)	N/A
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	61.8	119 (-1%)	377 (-1%)	741 (-1%)	1,467 (-1%)	2,921 (-1%)	N/A
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	106	208	692	1,363	2,707	5,395	N/A
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	0.535	0.537 (-1%)	0.511 (-1%)	0.510	0.508 (-1%)	0.508 (-1%)	N/A
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	66.4
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	107
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	0.589

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric	0 registered classes	1 registered classes
tx_size_in_bytes	82,705	664,768

Transaction size based on fee payment method

| Metric | |
| - | |

Transaction processing duration by data writes.

Metric	0 new note hashes	1 new note hashes	2 new note hashes
tx_pxe_processing_time_ms	12,013	4,202	76,906

Metric	1 public data writes	2 public data writes	3 public data writes	4 public data writes	8 public data writes
tx_sequencer_processing_time_ms	3,224	2,113 (+1%)	6,018 (-1%)	2,279	2,583

[LHerskind]

Seems fine to me, think good to merge into 6652, so each pr of the stack is fully passing CI as well, but this is a quite nice way for seeing that the tests indeed fails without needing to check much locally 👍