feat: historical access of key getters, fixing logic in contracts after rotation

[sklppy88]

Resolves #6312.

[sklppy88]

• fix: adding encrypted logs test #6662
• feat: historical access of key getters, fixing logic in contracts after rotation #6656 👈
• fix: shared mutable private getter delay change fix - failing test #6654 : 1 other dependent PR (#6655 )
• fix: shared mutable private getter fixes #6652 : 1 other dependent PR (#6653 )
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @sklppy88 and the rest of your teammates on Graphite

[AztecBot]

Benchmark results

Metrics with a significant change:

• protocol_circuit_witness_generation_time_in_ms (private-kernel-reset-small): 2,589 (+26%)
• protocol_circuit_witness_generation_time_in_ms (root-parity): 86.3 (+40%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Proof generation

Each column represents the number of threads used in proof generation.

Metric	1 threads	4 threads	16 threads	32 threads	64 threads
proof_construction_time_sha256	5,747	1,560	739 (+4%)	780 (+3%)	791 (+1%)

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	8 txs	32 txs	64 txs
l1_rollup_calldata_size_in_bytes	1,412	1,412	1,412
l1_rollup_calldata_gas	9,428	9,440	9,476
l1_rollup_execution_gas	616,069	616,081	616,117
l2_block_processing_time_in_ms	1,303 (+1%)	4,811	9,565
l2_block_building_time_in_ms	47,083	186,582 (-1%)	373,071
l2_block_rollup_simulation_time_in_ms	46,913	185,948 (-1%)	371,821
l2_block_public_tx_process_time_in_ms	25,091	105,052 (-1%)	214,107

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric	3 blocks	5 blocks
node_history_sync_time_in_ms	9,720 (+3%)	14,393
node_database_size_in_bytes	14,487,632	21,377,104
pxe_database_size_in_bytes	18,071	29,868

Circuits stats

Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.

Circuit	simulation_time_in_ms	witness_generation_time_in_ms	proving_time_in_ms	input_size_in_bytes	output_size_in_bytes	proof_size_in_bytes	num_public_inputs	size_in_gates
private-kernel-init	164	3,508 (-1%)	24,259 (-1%)	20,630	64,614	89,536	2,731	1,048,576
private-kernel-inner	626	4,018 (-1%)	52,768	92,318	64,614	89,536	2,731	2,097,152
private-kernel-tail	549	2,699 (-2%)	43,442 (+3%)	90,237	77,498	10,656	266	2,097,152
base-parity	6.61 (+2%)	1,164 (-8%)	2,810 (+1%)	128	64.0	2,208	2.00	131,072
root-parity	49.3 (+1%)	⚠️ 86.3 (+40%)	50,592	27,084	64.0	2,720	18.0	2,097,152
base-rollup	783 (+1%)	2,396 (-2%)	88,751 (+1%)	119,610	756	3,648	47.0	4,194,304
root-rollup	112	76.0 (-10%)	23,013 (+1%)	25,297	620	3,456	41.0	1,048,576
public-kernel-app-logic	529 (+1%)	2,791 (-5%)	50,966 (-1%)	104,941	86,302	114,784	3,520	2,097,152
public-kernel-tail	1,198 (+1%)	23,994	178,413 (-2%)	395,386	7,522	10,656	266	8,388,608
private-kernel-reset-small	597 (+1%)	⚠️ 2,589 (+26%)	48,288 (-2%)	120,733	64,614	89,536	2,731	2,097,152
merge-rollup	29.5 (+3%)	N/A	N/A	16,534	756	N/A	N/A	N/A
public-kernel-setup	629 (+1%)	N/A	N/A	104,941	86,302	N/A	N/A	N/A
public-kernel-teardown	532 (+2%)	N/A	N/A	104,941	86,302	N/A	N/A	N/A
private-kernel-tail-to-public	N/A	8,230	92,637 (-2%)	N/A	N/A	114,784	3,520	4,194,304

Stats on running time collected for app circuits

Function	input_size_in_bytes	output_size_in_bytes	witness_generation_time_in_ms	proof_size_in_bytes	proving_time_in_ms	size_in_gates	num_public_inputs
ContractClassRegisterer:register	1,344	9,944	460	N/A	N/A	N/A	N/A
ContractInstanceDeployer:deploy	1,408	9,944	41.3 (+1%)	N/A	N/A	N/A	N/A
MultiCallEntrypoint:entrypoint	1,920	9,944	1,431	N/A	N/A	N/A	N/A
SchnorrAccount:constructor	1,312	9,944	1,000	N/A	N/A	N/A	N/A
SchnorrAccount:entrypoint	2,304	9,944	2,128 (+1%)	16,768	50,455 (-4%)	2,097,152	457
Token:privately_mint_private_note	1,280	9,944	1,099 (-1%)	N/A	N/A	N/A	N/A
Token:transfer	1,376	9,944	4,014 (-1%)	16,768	56,992 (-1%)	2,097,152	457
Benchmarking:create_note	1,312	9,944	988 (+1%)	N/A	N/A	N/A	N/A
FPC:fee_entrypoint_public	1,344	9,944	229	N/A	N/A	N/A	N/A
SchnorrAccount:spend_private_authwit	1,280	9,944	77.3	N/A	N/A	N/A	N/A
Token:unshield	1,376	9,944	3,261	N/A	N/A	N/A	N/A
FPC:fee_entrypoint_private	1,376	9,944	4,061	N/A	N/A	N/A	N/A

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	16 leaves	64 leaves	128 leaves	512 leaves	1024 leaves	2048 leaves	4096 leaves	32 leaves
batch_insert_into_append_only_tree_16_depth_ms	10.4	17.0 (-1%)	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.7	31.8	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.603	0.520 (-1%)	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	48.9 (-1%)	76.3	247	479	929	1,843	N/A
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	95.9	159	543	1,055	2,079	4,127	N/A
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	0.496 (-1%)	0.470	0.449	0.447 (+1%)	0.440	0.439	N/A
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	58.2	112 (-1%)	354 (-1%)	704 (+1%)	1,386	2,757	N/A
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	106	208	692	1,363	2,707	5,395	N/A
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	0.504	0.504	0.480 (-1%)	0.484 (+1%)	0.479	0.478	N/A
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	62.5
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	107
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	0.554

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric	0 registered classes	1 registered classes
tx_size_in_bytes	83,794	665,117

Transaction size based on fee payment method

| Metric | |
| - | |

[LHerskind]

I quite like this as it is very explicit about the keys that you are picking 👀

There are a few things that are related to diff from earlier, but should be addressed with a gt sync, likely because it have not been rebased after partial merges higher up. When merged it this should be good to go 👍

[LHerskind]

For the keys might makes sense just to do a single trait for these? Not as separated as the other inclusions so reduces the boilerplate a bit 🤷

[sklppy88]

Good point, I like this too. Thanks for the shout.

[LHerskind]

[Re: line 114]

Unrelated to this pr, but this one is still slightly painful in my eyes as it is just calling the oracle so we have just "hidden" that we are doing an oracle call and not a constrained call. Think it would be better if we deal with this as an oracle directly to not mix it up, but should likely be done as part of #6543

See this comment inline on Graphite.

[LHerskind]

[LHerskind]

👍