private_kernel__sim split in inner/init variants#732
Merged
Conversation
added 6 commits
June 1, 2023 07:41
LeilaWang
requested changes
Jun 1, 2023
LeilaWang
left a comment
LeilaWang
left a comment
Contributor
There was a problem hiding this comment.
Look good to me! Only one tiny but nice thing to add to test :)
dbanks12
approved these changes
Jun 1, 2023
dbanks12
left a comment
dbanks12
left a comment
Contributor
There was a problem hiding this comment.
Lgtm once Leila approves your tweak.Great work!
I'm on my phone, but.before I forget, @jeanmon can you see if there is already an existing ticket to convert all circuits cbinds to the new msgpack format? And if not can you create that ticket? Thank you 🙏
LeilaWang
approved these changes
Jun 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This resolves #502
Checklist: