Skip to content

Tx payloads in binary form in HttpNode + tests#929

Merged
benesjan merged 29 commits into
masterfrom
janb/http-node-tests
Jul 11, 2023
Merged

Tx payloads in binary form in HttpNode + tests#929
benesjan merged 29 commits into
masterfrom
janb/http-node-tests

Conversation

@benesjan

@benesjan benesjan commented Jun 29, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

  1. Fixes Use binary data format for tx payloads in http-node #817
  2. Fixes Add tests around http-node #818
  3. Merges encrypted and unencrypted logs function to reduce redundancy.
  4. Aztec Node returns version and chainId as a number instead of a field.
  5. Few fixes in HttpNode (one of those severe - incorrectly decoding hex string resulting in incorrect root value).
  6. Unified Tx mock functions.

Checklist:

  • I have reviewed my diff in github, line by line.
  • Every change is related to the PR description.
  • I have linked this pull request to the issue(s) that it resolves.
  • There are no unexpected formatting changes, superfluous debug logs, or commented-out code.
  • The branch has been merged or rebased against the head of its merge target.
  • I'm happy for the PR to be merged at the reviewer's next convenience.

@benesjan benesjan marked this pull request as draft June 29, 2023 12:46
@benesjan benesjan force-pushed the janb/http-node-tests branch 2 times, most recently from bad3555 to c7de75e Compare June 30, 2023 11:27
@benesjan benesjan marked this pull request as ready for review June 30, 2023 11:34
@benesjan benesjan requested a review from PhilWindle June 30, 2023 11:34
@benesjan benesjan force-pushed the janb/http-node-tests branch 2 times, most recently from 0c00435 to 9ce9127 Compare July 3, 2023 09:50
benesjan added 20 commits July 3, 2023 10:01
@benesjan benesjan force-pushed the janb/http-node-tests branch from 68c8506 to 409de41 Compare July 3, 2023 10:02
@benesjan benesjan changed the title HttpNode tests Tx payloads in binary form in HttpNode + tests Jul 3, 2023
@benesjan benesjan mentioned this pull request Jul 3, 2023
Closed
PhilWindle
PhilWindle requested changes Jul 10, 2023
View reviewed changes
Comment thread yarn-project/archiver/src/archiver/archiver_store.ts Outdated
@benesjan benesjan force-pushed the janb/http-node-tests branch from fba8ce0 to cfaa9cb Compare July 10, 2023 11:37
@benesjan benesjan requested a review from PhilWindle July 10, 2023 11:49
PhilWindle
PhilWindle requested changes Jul 11, 2023
View reviewed changes
Comment thread yarn-project/archiver/src/archiver/archiver_store.ts Outdated
* @returns True if the operation is successful.
*/
addUnencryptedLogs(data: L2BlockL2Logs[]): Promise<boolean>;
addLogs(data: L2BlockL2Logs[], logType: 'encrypted' | 'unencrypted'): Promise<boolean>;

@PhilWindle PhilWindle Jul 11, 2023

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be an enum now?

@benesjan benesjan Jul 11, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right. Addressed in 4a6388a

@benesjan benesjan enabled auto-merge (squash) July 11, 2023 12:37
@benesjan benesjan merged commit ea56329 into master Jul 11, 2023
@benesjan benesjan deleted the janb/http-node-tests branch July 11, 2023 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PhilWindle PhilWindle PhilWindle approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add tests around http-node Use binary data format for tx payloads in http-node

2 participants

@benesjan @PhilWindle