Skip to content

Native and Circuit: Contract Deployment Logic in PKC#125

Merged
suyash67 merged 12 commits into
masterfrom
sb/contract-deployment-in-pkc
Mar 30, 2023
Merged

Native and Circuit: Contract Deployment Logic in PKC#125
suyash67 merged 12 commits into
masterfrom
sb/contract-deployment-in-pkc

Conversation

@suyash67

@suyash67 suyash67 commented Mar 29, 2023

Copy link
Copy Markdown
Contributor

Description

Adding native and circuit logic for contract deployment in private kernel circuit. Still adding tests...

Depends on: AztecProtocol/barretenberg#291

🛑 The private kernel circuit (at this point) works and all the tests work. BUT the contract deployement test fails when we verify the final proof. This is potentially because of a wire hanging somewhere that unsatisfying circuit.

🛑 The contract deployment test fails because of push error in the nullifier vector.

Checklist:

  • I have reviewed my diff in github, line by line.
  • Every change is related to the PR description.
  • I have linked this pull request to the issue(s) that it resolves.
  • There are no unexpected formatting changes, superfluous debug logs, or commented-out code.
  • There are no circuit changes, OR specifications in /specs have been updated.
  • There are no circuit changes, OR a cryptographer has been assigned for review.
  • I've updated any terraform that needs updating (e.g. environment variables) for deployment.
  • The branch has been rebased against the head of its merge target.
  • I'm happy for the PR to be merged at the reviewer's next convenience.
  • New functions, classes, etc. have been documented according to the doxygen comment format. Classes and structs must have @brief describing the intended functionality.
  • If existing code has been modified, such documentation has been added or updated.

Note
If you are updating the submodule, please make sure you do it in its own special PR and avoid making changes to the submodule as a part of other PRs.
To update a submodule, you can run the following commands:

$ git submodule update --recursive

Alternatively, you can select a particular commit in barretenberg/aztec3 that you wish to point to:

$ cd barretenberg
$ git pull origin aztec3        # This will point to the latest commit in `barretenberg/aztec3`
$ git checkout <commit_hash>    # Use this if you wish to point to a particular commit.
$ cd ..
$ git add . && git commit -m <commit_msg>
$ git push

suyash67 and others added 8 commits March 29, 2023 17:23
Co-authored-by: Michael Connor <iAmMichaelConnor@users.noreply.github.com>
The private kernel circuit (at this point) works and all the tests work. BUT the contract deployement test fails when we verify the final proof. This is potentially because of a wire hanging somewhere that unsatisfying circuit.
@suyash67 suyash67 force-pushed the sb/contract-deployment-in-pkc branch from 5472295 to b6f66cf Compare March 29, 2023 17:26
suyash67 and others added 4 commits March 29, 2023 17:49
* fix: contract_deployment test bug

* Fix native array to array push.

---------

Co-authored-by: Suyash Bagad <suyashnbagad1997@gmail.com>
@suyash67 suyash67 merged commit 90a735e into master Mar 30, 2023
@suyash67 suyash67 deleted the sb/contract-deployment-in-pkc branch March 30, 2023 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants