Skip to content

fix: contract_deployment test bug#138

Merged
suyash67 merged 2 commits into
sb/contract-deployment-in-pkcfrom
mc/fix-basic-contract-deployment-bug
Mar 30, 2023
Merged

fix: contract_deployment test bug#138
suyash67 merged 2 commits into
sb/contract-deployment-in-pkcfrom
mc/fix-basic-contract-deployment-bug

Conversation

@iAmMichaelConnor

Copy link
Copy Markdown
Contributor

Description

Please provide a paragraph or two giving a summary of the change, including relevant motivation and context.

Checklist:

  • I have reviewed my diff in github, line by line.
  • Every change is related to the PR description.
  • I have linked this pull request to the issue(s) that it resolves.
  • There are no unexpected formatting changes, superfluous debug logs, or commented-out code.
  • There are no circuit changes, OR specifications in /specs have been updated.
  • There are no circuit changes, OR a cryptographer has been assigned for review.
  • I've updated any terraform that needs updating (e.g. environment variables) for deployment.
  • The branch has been rebased against the head of its merge target.
  • I'm happy for the PR to be merged at the reviewer's next convenience.
  • New functions, classes, etc. have been documented according to the doxygen comment format. Classes and structs must have @brief describing the intended functionality.
  • If existing code has been modified, such documentation has been added or updated.

Note
If you are updating the submodule, please make sure you do it in its own special PR and avoid making changes to the submodule as a part of other PRs.
To update a submodule, you can run the following commands:

$ git submodule update --recursive

Alternatively, you can select a particular commit in barretenberg/aztec3 that you wish to point to:

$ cd barretenberg
$ git pull origin aztec3        # This will point to the latest commit in `barretenberg/aztec3`
$ git checkout <commit_hash>    # Use this if you wish to point to a particular commit.
$ cd ..
$ git add . && git commit -m <commit_msg>
$ git push

@dbanks12 dbanks12 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. And nice catch with the constructor vk!

@suyash67 suyash67 merged commit 769d66b into sb/contract-deployment-in-pkc Mar 30, 2023
@suyash67 suyash67 deleted the mc/fix-basic-contract-deployment-bug branch March 30, 2023 13:40
suyash67 added a commit that referenced this pull request Mar 30, 2023
* initial commit.

* remove old todo

* native pkc contract deployment.

* Fix `abis__hash_constructor`.

* Contract deployment test wip.

* Fix contract dep test.

Co-authored-by: Michael Connor <iAmMichaelConnor@users.noreply.github.com>

* WARNING:

The private kernel circuit (at this point) works and all the tests work. BUT the contract deployement test fails when we verify the final proof. This is potentially because of a wire hanging somewhere that unsatisfying circuit.

* Fix c_bind test.

* Fix test.

* Fix native private kernel test.

* fix: contract_deployment test bug (#138)

* fix: contract_deployment test bug

* Fix native array to array push.

---------

Co-authored-by: Suyash Bagad <suyashnbagad1997@gmail.com>

---------

Co-authored-by: Michael Connor <iAmMichaelConnor@users.noreply.github.com>
Co-authored-by: Michael Connor <mike@aztecprotocol.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants