fix: contract_deployment test bug#138
Merged
suyash67 merged 2 commits intoMar 30, 2023
Merged
Conversation
dbanks12
approved these changes
Mar 30, 2023
dbanks12
left a comment
Contributor
There was a problem hiding this comment.
Looks good. And nice catch with the constructor vk!
suyash67
added a commit
that referenced
this pull request
Mar 30, 2023
* initial commit. * remove old todo * native pkc contract deployment. * Fix `abis__hash_constructor`. * Contract deployment test wip. * Fix contract dep test. Co-authored-by: Michael Connor <iAmMichaelConnor@users.noreply.github.com> * WARNING: The private kernel circuit (at this point) works and all the tests work. BUT the contract deployement test fails when we verify the final proof. This is potentially because of a wire hanging somewhere that unsatisfying circuit. * Fix c_bind test. * Fix test. * Fix native private kernel test. * fix: contract_deployment test bug (#138) * fix: contract_deployment test bug * Fix native array to array push. --------- Co-authored-by: Suyash Bagad <suyashnbagad1997@gmail.com> --------- Co-authored-by: Michael Connor <iAmMichaelConnor@users.noreply.github.com> Co-authored-by: Michael Connor <mike@aztecprotocol.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please provide a paragraph or two giving a summary of the change, including relevant motivation and context.
Checklist:
/specshave been updated.@briefdescribing the intended functionality.