Skip to content

feat: Add pkgconfig output for installed target#208

Merged
dbanks12 merged 3 commits into
masterfrom
phated/pkgconfig
Mar 7, 2023
Merged

feat: Add pkgconfig output for installed target#208
dbanks12 merged 3 commits into
masterfrom
phated/pkgconfig

Conversation

@phated

@phated phated commented Mar 7, 2023

Copy link
Copy Markdown

Description

Closes #203

This adds a pkg-config install target so we can provide details for consuming barretenberg via pkg-config. I also needed to fix the PROJECT_VERSION variable so we output the correct version in pkg-config file. And I added comments that @dbanks12 asked for in #185

Checklist:

  • I have reviewed my diff in github, line by line.
  • Every change is related to the PR description.
  • I have linked this pull request to the issue(s) that it resolves.
  • There are no unexpected formatting changes, superfluous debug logs, or commented-out code.
  • There are no circuit changes, OR specifications in /markdown/specs have been updated.
  • There are no circuit changes, OR a cryptographer has been assigned for review.
  • I've updated any terraform that needs updating (e.g. environment variables) for deployment.
  • The branch has been rebased against the head of its merge target.
  • I'm happy for the PR to be merged at the reviewer's next convenience.
  • New functions, classes, etc. have been documented according to the doxygen comment format. Classes and structs must have @brief describing the intended functionality.
  • If existing code has been modified, such documentation has been added or updated.

@phated phated requested a review from dbanks12 March 7, 2023 17:33
@phated phated changed the title Phated/pkgconfig feat: Add pkgconfig output for installed target Mar 7, 2023
@dbanks12 dbanks12 merged commit d85a365 into master Mar 7, 2023
@dbanks12 dbanks12 deleted the phated/pkgconfig branch March 7, 2023 18:22
ludamad pushed a commit to AztecProtocol/aztec-packages that referenced this pull request Jul 22, 2023
…enberg#208)

* feat: Add pkgconfig output for installed target

* fix: Specify version with the project function

* chore: Add documentation to install targets
ludamad pushed a commit to AztecProtocol/aztec-packages that referenced this pull request Jul 24, 2023
…enberg#208)

* feat: Add pkgconfig output for installed target

* fix: Specify version with the project function

* chore: Add documentation to install targets
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Consumable via pkg-config

2 participants