Skip to content

Updating all templates to use the devconatiner feature#2489

Merged
hemarina merged 10 commits into
Azure:mainfrom
aaronpowell:aaronpowell/devcontainer-feature-usage
Jul 13, 2023
Merged

Updating all templates to use the devconatiner feature#2489
hemarina merged 10 commits into
Azure:mainfrom
aaronpowell:aaronpowell/devcontainer-feature-usage

Conversation

@aaronpowell

@aaronpowell aaronpowell commented Jul 6, 2023

Copy link
Copy Markdown
Contributor

With #1118 merged, this PR updates all the templates except (swa templates and todo-java-postgresql-terraform) use the feature rather than installing the azd cli within the Dockerfile.

This PR is pending the publishing of the feature to the agreed container registry.

Closes #2490

Comment thread templates/common/.devcontainer/Dockerfile/base/Dockerfile
Comment thread templates/common/.devcontainer/devcontainer.json/aks/nodejs/devcontainer.json Outdated
Comment thread templates/common/.devcontainer/devcontainer.json/aks/nodejs/devcontainer.json Outdated
Comment thread templates/common/.devcontainer/Dockerfile/func/Dockerfile Outdated

@wbreza wbreza left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question about using stable as default version instead of latest. I would also expect that version is not required and by default it would use the latest stable release of azd.

Comment thread templates/common/.devcontainer/devcontainer.json/aks/nodejs/devcontainer.json Outdated
@aaronpowell
aaronpowell force-pushed the aaronpowell/devcontainer-feature-usage branch from d194c97 to 8907989 Compare July 10, 2023 23:56
@hemarina
hemarina marked this pull request as ready for review July 11, 2023 19:42
@hemarina
hemarina requested a review from karolz-ms as a code owner July 11, 2023 19:42
Comment thread ext/devcontainer/src/azd/README.md
@ellismg

ellismg commented Jul 11, 2023

Copy link
Copy Markdown
Member

/azp run azure-dev - repoman

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@ellismg

ellismg commented Jul 11, 2023

Copy link
Copy Markdown
Member

Looks like there are some issues with the PR that are getting caught by repoman now, @hemarina (https://dev.azure.com/azure-sdk/internal/_build/results?buildId=2910196&view=logs&j=dc5beac1-197e-530f-c839-b08cb3c610f0&t=0cca624c-13bf-5c9a-9485-f7429792da43).

I think that these jobs might not auto-fire because Aaron opened the PR. You can manually run them using the /azp command as I did above.

@hemarina

This comment was marked as duplicate.

@azure-pipelines

This comment was marked as duplicate.

@hemarina

This comment was marked as duplicate.

@azure-pipelines

This comment was marked as resolved.

@hemarina

This comment was marked as duplicate.

@azure-pipelines

This comment was marked as duplicate.

@hemarina

This comment was marked as duplicate.

@azure-pipelines

This comment was marked as duplicate.

@azure-sdk

Copy link
Copy Markdown
Collaborator

Repoman Generation Results

Repoman pushed changes to remotes for the following projects:

Project: azd-starter-bicep

Remote: azure-samples-staging

Branch: pr/2489

You can initialize this project with:

azd init -t Azure-Samples/azd-starter-bicep -b pr/2489

View Changes | Compare Changes


Project: azd-starter-terraform

Remote: azure-samples-staging

Branch: pr/2489

You can initialize this project with:

azd init -t Azure-Samples/azd-starter-terraform -b pr/2489

View Changes | Compare Changes


Project: todo-csharp-cosmos-sql

Remote: azure-samples-staging

Branch: pr/2489

You can initialize this project with:

azd init -t Azure-Samples/todo-csharp-cosmos-sql -b pr/2489

View Changes | Compare Changes


Project: todo-csharp-sql-swa-func

Remote: azure-samples-staging

Branch: pr/2489

You can initialize this project with:

azd init -t Azure-Samples/todo-csharp-sql-swa-func -b pr/2489

View Changes | Compare Changes


Project: todo-csharp-sql

Remote: azure-samples-staging

Branch: pr/2489

You can initialize this project with:

azd init -t Azure-Samples/todo-csharp-sql -b pr/2489

View Changes | Compare Changes


Project: todo-java-mongo-aca

Remote: azure-samples-staging

Branch: pr/2489

You can initialize this project with:

azd init -t Azure-Samples/todo-java-mongo-aca -b pr/2489

View Changes | Compare Changes


Project: todo-java-mongo

Remote: azure-samples-staging

Branch: pr/2489

You can initialize this project with:

azd init -t Azure-Samples/todo-java-mongo -b pr/2489

View Changes | Compare Changes


Project: todo-java-postgresql-terraform

Remote: azure-samples-staging

Branch: pr/2489

You can initialize this project with:

azd init -t Azure-Samples/todo-java-postgresql-terraform -b pr/2489

View Changes | Compare Changes


Project: todo-nodejs-mongo-aca

Remote: azure-samples-staging

Branch: pr/2489

You can initialize this project with:

azd init -t Azure-Samples/todo-nodejs-mongo-aca -b pr/2489

View Changes | Compare Changes


Project: todo-nodejs-mongo-aks

Remote: azure-samples-staging

Branch: pr/2489

You can initialize this project with:

azd init -t Azure-Samples/todo-nodejs-mongo-aks -b pr/2489

View Changes | Compare Changes


Project: todo-nodejs-mongo-swa-func

Remote: azure-samples-staging

Branch: pr/2489

You can initialize this project with:

azd init -t Azure-Samples/todo-nodejs-mongo-swa-func -b pr/2489

View Changes | Compare Changes


Project: todo-nodejs-mongo

Remote: azure-samples-staging

Branch: pr/2489

You can initialize this project with:

azd init -t Azure-Samples/todo-nodejs-mongo -b pr/2489

View Changes | Compare Changes


Project: todo-nodejs-mongo-terraform

Remote: azure-samples-staging

Branch: pr/2489

You can initialize this project with:

azd init -t Azure-Samples/todo-nodejs-mongo-terraform -b pr/2489

View Changes | Compare Changes


Project: todo-python-mongo-aca

Remote: azure-samples-staging

Branch: pr/2489

You can initialize this project with:

azd init -t Azure-Samples/todo-python-mongo-aca -b pr/2489

View Changes | Compare Changes


Project: todo-python-mongo-swa-func

Remote: azure-samples-staging

Branch: pr/2489

You can initialize this project with:

azd init -t Azure-Samples/todo-python-mongo-swa-func -b pr/2489

View Changes | Compare Changes


Project: todo-python-mongo

Remote: azure-samples-staging

Branch: pr/2489

You can initialize this project with:

azd init -t Azure-Samples/todo-python-mongo -b pr/2489

View Changes | Compare Changes


Project: todo-python-mongo-terraform

Remote: azure-samples-staging

Branch: pr/2489

You can initialize this project with:

azd init -t Azure-Samples/todo-python-mongo-terraform -b pr/2489

View Changes | Compare Changes


@hemarina
hemarina merged commit a68263d into Azure:main Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update templates to use azd devcontainer feature

7 participants