Skip to content

Remove template: java-postgresql#2498

Closed
vhvb1989 wants to merge 1 commit into
Azure:mainfrom
vhvb1989:remove-java-postgresql-template
Closed

Remove template: java-postgresql#2498
vhvb1989 wants to merge 1 commit into
Azure:mainfrom
vhvb1989:remove-java-postgresql-template

Conversation

@vhvb1989

@vhvb1989 vhvb1989 commented Jul 10, 2023

Copy link
Copy Markdown
Member

Removing template todo-java-postgresql from azure-dev.

Why:

@azure-sdk

Copy link
Copy Markdown
Collaborator

Repoman Generation Results

Repoman pushed changes to remotes for the following projects:
No changes detected.

@vhvb1989
vhvb1989 requested a review from danieljurek July 10, 2023 21:06

@wbreza wbreza left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I defer to @savannahostrowski since I don't know the intent of the template on whether or not it should ever make it to the Azure-Samples org or just stay as a user contributed Awesome AZD template.

@rajeshkamal5050

rajeshkamal5050 commented Jul 11, 2023

Copy link
Copy Markdown
Contributor

I defer to @savannahostrowski since I don't know the intent of the template on whether or not it should ever make it to the Azure-Samples org or just stay as a user contributed Awesome AZD template.

@vhvb1989 @savannahostrowski I believe the intention was to get them added in azure-dev #1792, synced to https://github.com/Azure-Samples/todo-java-postgresql-terraform and add to the default list of azd templates.

@yiliuTo @fangjian0423 is that right?

@yiliuTo

yiliuTo commented Jul 12, 2023

Copy link
Copy Markdown
Member

Hi @rajeshkamal5050

I believe the intention was to get them added in azure-dev #1792, synced to https://github.com/Azure-Samples/todo-java-postgresql-terraform and add to the default list of azd templates.

I think so, but I am not quite sure of the context about this template, maybe we can wait @fangjian0423 for the response when he is back next week?

@hemarina

Copy link
Copy Markdown
Contributor

This is related to #2489. If we decide to sync in Azure-Samples, we might want to update this template with devcontainer feature. Checking with @fangjian0423 if we could use https://github.com/devcontainers-contrib/features/tree/main/src/postgres-asdf. Otherwise, we will keep using dockerfile.

@hemarina hemarina mentioned this pull request Jul 13, 2023
@fangjian0423

Copy link
Copy Markdown
Contributor

hi @rajeshkamal5050

I believe the intention was to get them added in azure-dev #1792, synced to https://github.com/Azure-Samples/todo-java-postgresql-terraform and add to the default list of azd templates.

It should be added in azure-dev. Since the UI, app, build config/codes are exactly the same as what we have for other java templates. The delta just being the terraform modules.

@fangjian0423

Copy link
Copy Markdown
Contributor

This is related to #2489. If we decide to sync in Azure-Samples, we might want to update this template with devcontainer feature. Checking with @fangjian0423 if we could use https://github.com/devcontainers-contrib/features/tree/main/src/postgres-asdf. Otherwise, we will keep using dockerfile.

I think it should be support devcontainer feature, let me check how to support it.

@vhvb1989

Copy link
Copy Markdown
Member Author

Expecting to update this version and make the template public.

@vhvb1989 vhvb1989 closed this Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants