Skip to content

Enable telemetry for prod - #785

Merged
weikanglim merged 3 commits into
Azure:mainfrom
weikanglim:weilim/enable-prod-telemetry
Oct 4, 2022
Merged

Enable telemetry for prod#785
weikanglim merged 3 commits into
Azure:mainfrom
weikanglim:weilim/enable-prod-telemetry

Conversation

@weikanglim

@weikanglim weikanglim commented Sep 30, 2022

Copy link
Copy Markdown
Member
  • Remove feature guard
  • Remove ObjectId from telemetry collection
  • Classify daily (master merged) builds as prod
  • Use connection strings over instrumentation keys. Unfortunately, the appinsights SDK does not implement connection string parsing, and we had to implement our own. See schema here

Fixes #190

@weikanglim
weikanglim marked this pull request as ready for review September 30, 2022 23:15
@rajeshkamal5050 rajeshkamal5050 added the area/telemetry Telemetry, tracing, observability label Oct 4, 2022
@rajeshkamal5050 rajeshkamal5050 added this to the Release 0.3 milestone Oct 4, 2022

@ellismg ellismg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small hygiene things I noticed but nothing blocking.

Comment thread cli/azd/internal/telemetry/appinsights-exporter/endpoint_config.go
Comment thread cli/azd/internal/telemetry/telemetry_test.go
Comment thread cli/azd/internal/telemetry/appinsights-exporter/endpoint_config.go
@azure-sdk

Copy link
Copy Markdown
Collaborator

Azure Dev CLI Install Instructions

Install scripts

MacOS/Linux

May elevate using sudo on some platforms and configurations

bash:

curl -fsSL https://azuresdkreleasepreview.blob.core.windows.net/azd/standalone/pr/785/uninstall-azd.sh | bash;
curl -fsSL https://azuresdkreleasepreview.blob.core.windows.net/azd/standalone/pr/785/install-azd.sh | bash -s -- --base-url https://azuresdkreleasepreview.blob.core.windows.net/azd/standalone/pr/785 --version '' --verbose

pwsh:

Invoke-RestMethod 'https://azuresdkreleasepreview.blob.core.windows.net/azd/standalone/pr/785/uninstall-azd.ps1' -OutFile uninstall-azd.ps1; ./uninstall-azd.ps1
Invoke-RestMethod 'https://azuresdkreleasepreview.blob.core.windows.net/azd/standalone/pr/785/install-azd.ps1' -OutFile install-azd.ps1; ./install-azd.ps1 -BaseUrl 'https://azuresdkreleasepreview.blob.core.windows.net/azd/standalone/pr/785' -Version '' -Verbose

Windows

powershell -c "Set-ExecutionPolicy Bypass Process; irm 'https://azuresdkreleasepreview.blob.core.windows.net/azd/standalone/pr/785/uninstall-azd.ps1' > uninstall-azd.ps1; ./uninstall-azd.ps1;"
powershell -c "Set-ExecutionPolicy Bypass Process; irm 'https://azuresdkreleasepreview.blob.core.windows.net/azd/standalone/pr/785/install-azd.ps1' > install-azd.ps1; ./install-azd.ps1 -BaseUrl 'https://azuresdkreleasepreview.blob.core.windows.net/azd/standalone/pr/785' -Version '' -Verbose;"

Standalone Binary

Container

docker run -it azdevcliextacr.azurecr.io/azure-dev:pr-785

@weikanglim
weikanglim merged commit 14a7281 into Azure:main Oct 4, 2022
@weikanglim
weikanglim deleted the weilim/enable-prod-telemetry branch February 28, 2023 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/telemetry Telemetry, tracing, observability

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Capture azd Commands Telemetry (enable for production)

4 participants