[Ready for review] Added CDN Profiles to fluent by hovsepm · Pull Request #1257 · Azure/azure-sdk-for-java

hovsepm · 2016-11-02T22:20:00Z

No description provided.

# Conflicts: # azure/src/main/java/com/microsoft/azure/management/Azure.java

martinsawicki · 2016-11-19T17:47:51Z

+        Wrapper<EndpointInner> {
+
+    /**
+     * Get the originHostHeader value.


We use the 3rd person declarative mood for member descriptions, so "Gets" not "Get", "Specifies" not "Specify", etc.
pls scrub the Javadocs to get them consistent with that. thx

Fixed everywhere in CDN public interfaces

martinsawicki · 2016-11-19T17:50:36Z

+    /**
+     * Get the originHostHeader value.
+     *
+     * @return the originHostHeader value


this is not a user-facing statement, as it is meaningless. i know this is the wording in the auto-gen'd one. We need to make it sound user-facing. i.e "origin host header" not "originHostHeader" value. pls scrub the javadocs with this in mind.

fixed everywhere.

martinsawicki · 2016-11-19T17:51:26Z

+    /**
+     * Get the isHttpsAllowed value.
+     *
+     * @return the isHttpsAllowed value


for the Boolean, one descriptive way would be to say "true is HTTP is allowed, else false"

martinsawicki · 2016-11-19T17:52:49Z

+        Wrapper<EndpointInner> {
+
+    /**
+     * Get the originHostHeader value.


We use the 3rd person declarative mood for member descriptions, so "Gets" not "Get", "Specifies" not "Specify", etc.
pls scrub the Javadocs to get them consistent with that. thx

Btw - on parameters properties returning a value, we don't need the description, just the @return, so:
@return origin host header

martinsawicki · 2016-11-19T17:53:46Z

+             */
+            interface PremiumEndpoint<ParentT> {
+                /**
+                 * Specifies the Origin of the CDN Endpoint.


there is no need to capitalize "origin"

martinsawicki · 2016-11-19T17:54:11Z

+            }
+        }
+
+        /** The final stage of the CDN profile Standard Akamai or Standard Verizone endpoint definition.


Verizon misspelled

martinsawicki · 2016-11-19T17:55:01Z

+            WithStandardAttach<ParentT> withCustomDomain(String hostName);
+        }
+
+        /** The final stage of the CDN profile Premium Verizone endpoint definition.


pls correct all occurrences of the misspelled "Verizone"

martinsawicki · 2016-11-19T17:55:31Z

+                UpdateDefinitionStages.WithStandardAttach<ParentT> withOrigin(String originName, String originHostName);
+
+                /**
+                 * Specifies the Origin of the CDN Endpoint.


no need to capitalize "origin"

martinsawicki · 2016-11-19T17:57:54Z

+     * @param profileName Name of the CDN profile which is unique within the resource group.
+     * @param endpointName Name of the endpoint under the profile which is unique globally.
+     */
+    void endpointStart(String resourceGroupName, String profileName, String endpointName);


method names that indicate action start with a verb, not noun --> startEndpoint()

martinsawicki · 2016-11-19T17:58:17Z

+     * @param profileName Name of the CDN profile which is unique within the resource group.
+     * @param endpointName Name of the endpoint under the profile which is unique globally.
+     */
+    void endpointStop(String resourceGroupName, String profileName, String endpointName);


stopEndpoint(...)

martinsawicki · 2016-11-19T17:58:52Z

+     * @param endpointName Name of the endpoint under the profile which is unique globally.
+     * @param contentPaths The path to the content to be purged. Can describe a file path or a wild card directory.
+     */
+    void endpointPurgeContent(String resourceGroupName, String profileName, String endpointName, List<String> contentPaths);


--> purgeEndpointContent(...)

martinsawicki · 2016-11-19T17:59:34Z

+     * @param endpointName Name of the endpoint under the profile which is unique globally.
+     * @param contentPaths The path to the content to be loaded. Should describe a file path.
+     */
+    void endpointLoadContent(String resourceGroupName, String profileName, String endpointName, List<String> contentPaths);


--> loadEndpointContent(...)

martinsawicki · 2016-11-19T18:02:10Z

@@ -0,0 +1,65 @@
+/**


in the future, pls do not include auto-gen'd code with hand-written code in the same PR. Makes full code reviews pretty much impossible :-)

martinsawicki

could we pls have this PR split into PR with auto-gen'd code and PR with hand-written code? Having them all mixed together makes a proper code review pretty much impossible :-)

hovsepm · 2016-11-21T23:40:15Z

Working on rebase to split generated and handcrafted files in two separate commits that will make code review easier...

Added CDN Profiles

41df585

azurecla added the cla-not-required label Nov 2, 2016

Hovsep Mkrtchyan added 8 commits November 2, 2016 15:58

Regenerated after CDN swagger spec change

ff00dc6

Addressed review feedbacks

3ccda8a

Merge branch 'master' of https://github.com/Azure/azure-sdk-for-java

f96af92

Intermediate check-in.

240e8e5

Merge branch 'master' of https://github.com/Azure/azure-sdk-for-java

e68d088

# Conflicts: # azure/src/main/java/com/microsoft/azure/management/Azure.java

Finished CDN implementation.

6de119e

Fixed CI build errors.

acbefb0

Merge branch 'master' of https://github.com/Azure/azure-sdk-for-java

4b4bf06

hovsepm changed the title ~~[In Progress] Added CDN Profiles to fluent~~ [Ready for review] Added CDN Profiles to fluent Nov 17, 2016

martinsawicki reviewed Nov 19, 2016

View reviewed changes

martinsawicki suggested changes Nov 19, 2016

View reviewed changes

Addressed review feedbacks and added tests to Azure Management package.

dff8e00

Merge branch 'master' of https://github.com/Azure/azure-sdk-for-java

8191aa0

hovsepm mentioned this pull request Nov 21, 2016

[Ready for review] Added CDN Profiles to fluent (Rebased) #1288

Merged

hovsepm closed this Nov 21, 2016

sima-zhu pushed a commit to sima-zhu/azure-sdk-for-java that referenced this pull request Mar 21, 2019

Remove Gemfile.lock and adding it to .gitignore (Azure#1257)

c6106a3

Uh oh!

Conversation

hovsepm commented Nov 2, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

martinsawicki left a comment

Choose a reason for hiding this comment

Uh oh!

hovsepm commented Nov 21, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants