[Ready for review] Added CDN Profiles to fluent (Rebased)#1288
Conversation
|
@martinsawicki you can review code by commits now. Please let me know if this is still not reviewable. |
There was a problem hiding this comment.
minor, but for simple "getters" we do not need a description -- @return host header is enough
There was a problem hiding this comment.
doesn't this return a modifiable list? Might need to go through Collections.unmodifiableList(...). In general, unless they are PagedLists underneath, we return static lists as immutable, which is what unmodifiableList achieves..
There was a problem hiding this comment.
changed to unmodifiable list.
There was a problem hiding this comment.
is this list ultimately returned to the user code? If so, shouldn't it go through Collections.unmodifiableList?
There was a problem hiding this comment.
Fixed this as well.
There was a problem hiding this comment.
do we have a test of a "without"-er somewhere as well? (isn't .withoutEndpoint(name) possible?)
There was a problem hiding this comment.
it is covered here - 962de50#diff-a2dcc8b4d0226a01115fecc7168730a1R142
3 participants
Rebased PR #1257 into 2 commits. First one is generated code the second one is Hand crafted.