Skip to content

Live test pipeline setup - #16213

Merged
samvaity merged 9 commits into
Azure:masterfrom
samvaity:test-resources-ma
Nov 2, 2020
Merged

Live test pipeline setup#16213
samvaity merged 9 commits into
Azure:masterfrom
samvaity:test-resources-ma

Conversation

@samvaity

@samvaity samvaity commented Oct 13, 2020

Copy link
Copy Markdown
Member

Configure the live test pipeline to use the shared resources from the test subscription.
Pull changes from core redactor for empty value redaction bug fix.

Live test pipeline - https://dev.azure.com/azure-sdk/internal/_build/results?buildId=599834&view=results

@samvaity

Copy link
Copy Markdown
Member Author

/azp run java - metricsadvisor - tests

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@samvaity

Copy link
Copy Markdown
Member Author

/azp run java - metricsadvisor - tests

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@samvaity samvaity self-assigned this Oct 13, 2020
@samvaity samvaity changed the title Live test pipeline Live test pipeline setup Oct 13, 2020
@samvaity

Copy link
Copy Markdown
Member Author

/azp run java - metricsadvisor - tests

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@check-enforcer

Copy link
Copy Markdown

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run java - [service] - ci

@samvaity
samvaity force-pushed the test-resources-ma branch 4 times, most recently from f688f48 to c880bfb Compare October 29, 2020 22:27

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reported as service issue #_53

@samvaity
samvaity force-pushed the test-resources-ma branch 5 times, most recently from 70a6f2b to 799cb08 Compare November 1, 2020 21:18
@samvaity
samvaity force-pushed the test-resources-ma branch 2 times, most recently from 1f4323c to 064d178 Compare November 1, 2020 22:47
} finally {
Mono<Void> deleteAnomalyAlertConfiguration
= client.deleteAnomalyAlertConfiguration(alertConfigurationId.get());
StepVerifier.create(deleteAnomalyAlertConfiguration).verifyComplete();

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In finally should we attempt to clean up the resource only if the alertConfigurationId has a value (which means creation succeeded).

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the same comment for other applicable places we do the cleanup in finally.

<configuration>
<systemPropertyVariables>
<!-- Parallel runs disabled due to subscriber timeout issue causing failures in tests. -->
<junit.jupiter.execution.parallel.enabled>false</junit.jupiter.execution.parallel.enabled>

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should leave a TODO to determine the root cause and fix this.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#17069. Will add it to the code too.

Comment thread sdk/metricsadvisor/tests.yml
@samvaity
samvaity merged commit a95455b into Azure:master Nov 2, 2020
@samvaity
samvaity deleted the test-resources-ma branch June 22, 2021 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants