[MetricsAdvisor] API design and renaming updates - #16732
Merged
Merged
Conversation
Member
Author
|
Oh I need to fix the test pipeline first, will merge after #16213 |
samvaity
marked this pull request as draft
October 26, 2020 08:21
samvaity
force-pushed
the
api-updates
branch
2 times, most recently
from
November 2, 2020 03:46
41e409c to
a66fa4b
Compare
anuchandy
reviewed
Nov 2, 2020
Member
There was a problem hiding this comment.
Does it make sense to do a null check for params in this method as well? Today if a user calls listIncidentRootCases(null, incidentId,..) the error we throw is incident.detectionConfigurationId is required and cannot be null
samvaity
marked this pull request as ready for review
November 4, 2020 01:49
anuchandy
approved these changes
Nov 5, 2020
| A `data feed` is what Metrics Advisor ingests from the user-specified data source such as Cosmos structure stream, SQL query result, and so on. | ||
| A data feed contains rows of timestamps, zero or more dimensions, one or more metrics. Therefore, multiple metrics could share the same data source and even the same data feed. | ||
| A data feed is what Metrics Advisor ingests from the user-specified data source such as Cosmos structure stream, SQL query result, and so on. | ||
| It contains rows of timestamps, zero or more dimensions, one or more etrics. Therefore, multiple metrics could share the same data source and even the same data feed. |
Member
There was a problem hiding this comment.
nit; one or more etrics -> one or more metrics
| .setStartTime(startTime) | ||
| .setEndTime(endTime); | ||
|
|
||
| if (options.getFilter() != null) { |
Member
There was a problem hiding this comment.
should we also check for whether the option is not null before invoking getFilter
Member
There was a problem hiding this comment.
same comment for listAnomaliesForDetectionConfigNextPageAsync
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR
createdDataFeedmethod to take oneDataFeedobject.listValuesOfDimensionWithAnomaliesmethod tolistDimensionValuesWithAnomalies.ListValuesOfDimensionWithAnomaliesOptionsmethod toListDimensionValuesWithAnomaliesOptions.viewers,adminsand their accessors toviewerEmailsandadminEmailsrespectively onDataFeedOptionsmodel.DataSourceMissingDataPointFillTypetoDataFeedMissingDataPointFillType.MetricEnrichedSeriesDataandMetricSeriesDatamodel.setSeveritytosetSeverityRangeConditiononMetricAnomalyAlertConditionsmodel.Since this PR was getting too long, updates coming in follow up PR: