Skip to content

Update spring cloud sample for bug modification and api upgrade - #20195

Merged
saragluna merged 7 commits into
Azure:masterfrom
moarychan:feature/update-spring-cloud-sample-with-new-reactor-api
Mar 31, 2021
Merged

Update spring cloud sample for bug modification and api upgrade#20195
saragluna merged 7 commits into
Azure:masterfrom
moarychan:feature/update-spring-cloud-sample-with-new-reactor-api

Conversation

@moarychan

@moarychan moarychan commented Mar 29, 2021

Copy link
Copy Markdown
Member

Issue: Error found when running Spring samples of Event Hubs and should use Sinks API instead of EmitterProcessor

Changelogs

  • Use Sinks api instead of the deprecated EmitterProcessor, involving the EventHubs and Service Bus samples.
  • Use logger instead System.out.print.
  • Use com.azure:azure-core:1.14.1 package to fix conflicts for Event Hubs sample.

The to-do item "Update event hubs and service bus sample test case" will be processed in a new PR.

@ghost ghost added the azure-spring All azure-spring related issues label Mar 29, 2021
@saragluna saragluna modified the milestones: [2021] August, [2021] May Mar 30, 2021
@check-enforcer

Copy link
Copy Markdown

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run java - [service] - ci

@saragluna saragluna left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about we create another PR for the integration test changes?

@saragluna saragluna added azure-spring-eventhubs Spring event hubs related issues. azure-spring-eventhubs-kafka Spring event hubs kafka related issues. azure-spring-servicebus Spring service bus related issues. labels Mar 30, 2021

@saragluna saragluna left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

emitterProcessor.onNext(MessageBuilder.withPayload(message).build());
return ResponseEntity.ok("Sent!");
LOGGER.info("Going to add message {} to Sinks.Many.", message);
many.emitNext(MessageBuilder.withPayload(message).build(), Sinks.EmitFailureHandler.FAIL_FAST);

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you explain more on this method?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checkpoint-storage-account: [checkpoint-storage-account]
checkpoint-container: [checkpoint-container]
stream:
function:

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay, even though it makes no difference to me.

@saragluna
saragluna merged commit 7531146 into Azure:master Mar 31, 2021
@moarychan
moarychan deleted the feature/update-spring-cloud-sample-with-new-reactor-api branch April 9, 2021 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

azure-spring All azure-spring related issues azure-spring-eventhubs Spring event hubs related issues. azure-spring-eventhubs-kafka Spring event hubs kafka related issues. azure-spring-servicebus Spring service bus related issues.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Error found when running Spring samples of Event Hubs and should use Sinks API instead of EmitterProcessor

3 participants