Update spring cloud sample for bug modification and api upgrade - #20195
Conversation
|
This pull request is protected by Check Enforcer. What is Check Enforcer?Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass. Why am I getting this message?You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged. What should I do now?If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows: What if I am onboarding a new service?Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment: |
saragluna
left a comment
There was a problem hiding this comment.
How about we create another PR for the integration test changes?
| emitterProcessor.onNext(MessageBuilder.withPayload(message).build()); | ||
| return ResponseEntity.ok("Sent!"); | ||
| LOGGER.info("Going to add message {} to Sinks.Many.", message); | ||
| many.emitNext(MessageBuilder.withPayload(message).build(), Sinks.EmitFailureHandler.FAIL_FAST); |
There was a problem hiding this comment.
could you explain more on this method?
There was a problem hiding this comment.
You can some code snippet in this post https://spring.io/blog/2020/07/10/first-milestone-of-reactor-2020-0-codename-europium
| checkpoint-storage-account: [checkpoint-storage-account] | ||
| checkpoint-container: [checkpoint-container] | ||
| stream: | ||
| function: |
There was a problem hiding this comment.
okay, even though it makes no difference to me.
Issue: Error found when running Spring samples of Event Hubs and should use Sinks API instead of EmitterProcessor
Changelogs
Sinksapi instead of the deprecatedEmitterProcessor, involving the EventHubs and Service Bus samples.System.out.print.com.azure:azure-core:1.14.1package to fix conflicts for Event Hubs sample.The to-do item "Update event hubs and service bus sample test case" will be processed in a new PR.