Upgrade Sinks api for eventhub/servicebus IT case by moarychan · Pull Request #20343 · Azure/azure-sdk-for-java

moarychan · 2021-04-02T09:52:56Z

Related PR: Update spring cloud sample for bug modification and api upgrade

Changelog:

Upgrade Sinks api for eventhub IT case
Move eventhub binder' IT case to test_eventhubs module
Enable live test of eventhub binder sample IT case(Test first)

To-do list:

The same IT case update for other eventhub samples

saragluna · 2021-04-06T02:01:22Z

/azp run java - spring - tests

azure-pipelines · 2021-04-06T02:01:36Z

Azure Pipelines successfully started running 1 pipeline(s).

saragluna · 2021-04-07T02:26:25Z

/azp run java - spring - tests

azure-pipelines · 2021-04-07T02:26:35Z

Azure Pipelines successfully started running 1 pipeline(s).

check-enforcer · 2021-04-07T08:20:30Z

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run java - [service] - ci

saragluna · 2021-04-07T08:42:49Z

/azp run java - spring - tests

azure-pipelines · 2021-04-07T08:43:00Z

Azure Pipelines successfully started running 1 pipeline(s).

saragluna · 2021-04-08T04:56:58Z

/azp run java - spring - tests

azure-pipelines · 2021-04-08T04:57:10Z

Azure Pipelines successfully started running 1 pipeline(s).

…ture/upgrade-reactor-api-for-eventhub-servicebus-it-case

saragluna · 2021-04-08T05:39:53Z

/azp run java - spring - tests

azure-pipelines · 2021-04-08T05:40:06Z

Azure Pipelines successfully started running 1 pipeline(s).

saragluna · 2021-04-08T07:40:50Z

/azp run java - spring - tests

azure-pipelines · 2021-04-08T07:41:02Z

Azure Pipelines successfully started running 1 pipeline(s).

saragluna · 2021-04-08T09:24:26Z

/azp run java - spring - tests

azure-pipelines · 2021-04-08T09:24:38Z

Azure Pipelines successfully started running 1 pipeline(s).

…esource order in test-eventhub module.

yiliuTo · 2021-04-09T01:56:55Z

/azp run java - spring - tests

azure-pipelines · 2021-04-09T01:57:06Z

Azure Pipelines successfully started running 1 pipeline(s).

… namespace to run each kafka module.

yiliuTo · 2021-04-09T02:50:58Z

/azp run java - spring - tests

azure-pipelines · 2021-04-09T02:51:09Z

Azure Pipelines successfully started running 1 pipeline(s).

…ut disturbing each other.

yiliuTo · 2021-04-09T06:53:28Z

/azp run java - spring - tests

azure-pipelines · 2021-04-09T06:53:39Z

Azure Pipelines successfully started running 1 pipeline(s).

yiliuTo · 2021-04-09T07:55:05Z

/azp run java - spring - tests

azure-pipelines · 2021-04-09T07:55:16Z

Azure Pipelines successfully started running 1 pipeline(s).

saragluna

We should create another PR to address these issue.

saragluna · 2021-04-12T03:20:43Z

+  cloud:
+    azure:
+      eventhub:
+        connection-string: ${EVENTHUB_CONNECTION_STRING_BINDER}


We could the same event hub namespace and storage account, but a different event hub and storage container.

saragluna · 2021-04-12T03:21:36Z

+      "value": "[listKeys(resourceId('Microsoft.EventHub/namespaces/authorizationRules', variables('eventHubsNamespaceName'), variables('eventHubsNamespaceKeyName')), '2017-04-01').primaryConnectionString]"
+    }
+  }
+}


saragluna · 2021-04-12T03:24:08Z

+        definition: consume;supply
+      bindings:
+        consume-in-0:
+          destination: binder-test


we should think about how to name this destination

saragluna · 2021-04-12T03:24:27Z

+      "value": "[subscription().subscriptionId]"
+    }
+  }
+}


saragluna

LGTM, and another PR to address the above issues.

Moary Chen added 2 commits April 1, 2021 10:44

update package to com.azure.spring.test.eventhubs

b8d20be

Upgrade to Sinks api to emit message

def9a1e

moarychan requested review from backwind1233, chenrujun, jialindai, saragluna, stliu and yiliuTo as code owners April 2, 2021 09:52

ghost added the azure-spring All azure-spring related issues label Apr 2, 2021

Add timeout process for eventhub IT test case

a091a42

saragluna self-assigned this Apr 7, 2021

saragluna added azure-spring-eventhubs Spring event hubs related issues. azure-spring-servicebus Spring service bus related issues. labels Apr 7, 2021

fix bugs

82d13c6

Merge branch 'master'

45431e5

Add eventhub and container(storage) resources to each IT class to test

2a4ad55

Merge branch 'master' of github.com:Azure/azure-sdk-for-java into fea…

5a061ff

…ture/upgrade-reactor-api-for-eventhub-servicebus-it-case

Specify subscription id for kafka sample

c772e5a

Use system default variables for kafka sample configuration; update r…

b24dba7

…esource order in test-eventhub module.

Customize the variables for kafka sample resource file; use different…

9a9fb37

… namespace to run each kafka module.

Ensure name and value of each environment variable are isolated witho…

6b050c7

…ut disturbing each other.

fix bug

d055e50

saragluna reviewed Apr 12, 2021

View reviewed changes

saragluna approved these changes Apr 12, 2021

View reviewed changes

saragluna merged commit 4ad9a21 into Azure:master Apr 12, 2021

moarychan deleted the feature/upgrade-reactor-api-for-eventhub-servicebus-it-case branch April 15, 2021 04:36

moarychan mentioned this pull request Apr 15, 2021

Should use the different storage account and eventhub namespace variables for live tests #20698

Merged

benbp pushed a commit that referenced this pull request Apr 28, 2021

Use the new Sink API for Spring eventhubs/servicebus IT cases (#20343)

8987278

Uh oh!

Conversation

moarychan commented Apr 2, 2021 • edited by backwind1233 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

saragluna commented Apr 6, 2021

Uh oh!

azure-pipelines Bot commented Apr 6, 2021

Uh oh!

saragluna commented Apr 7, 2021

Uh oh!

azure-pipelines Bot commented Apr 7, 2021

Uh oh!

check-enforcer Bot commented Apr 7, 2021

What is Check Enforcer?

Why am I getting this message?

What should I do now?

What if I am onboarding a new service?

Uh oh!

saragluna commented Apr 7, 2021

Uh oh!

azure-pipelines Bot commented Apr 7, 2021

Uh oh!

saragluna commented Apr 8, 2021

Uh oh!

azure-pipelines Bot commented Apr 8, 2021

Uh oh!

saragluna commented Apr 8, 2021

Uh oh!

azure-pipelines Bot commented Apr 8, 2021

Uh oh!

saragluna commented Apr 8, 2021

Uh oh!

azure-pipelines Bot commented Apr 8, 2021

Uh oh!

saragluna commented Apr 8, 2021

Uh oh!

azure-pipelines Bot commented Apr 8, 2021

Uh oh!

yiliuTo commented Apr 9, 2021

Uh oh!

azure-pipelines Bot commented Apr 9, 2021

Uh oh!

yiliuTo commented Apr 9, 2021

Uh oh!

azure-pipelines Bot commented Apr 9, 2021

Uh oh!

yiliuTo commented Apr 9, 2021

Uh oh!

azure-pipelines Bot commented Apr 9, 2021

Uh oh!

yiliuTo commented Apr 9, 2021

Uh oh!

azure-pipelines Bot commented Apr 9, 2021

Uh oh!

saragluna left a comment

Choose a reason for hiding this comment

Uh oh!

saragluna Apr 12, 2021

Choose a reason for hiding this comment

Uh oh!

saragluna Apr 12, 2021

Choose a reason for hiding this comment

Uh oh!

saragluna Apr 12, 2021

Choose a reason for hiding this comment

Uh oh!

saragluna Apr 12, 2021

Choose a reason for hiding this comment

Uh oh!

saragluna left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

moarychan commented Apr 2, 2021 •

edited by backwind1233

Loading