Skip to content

Should use the different storage account and eventhub namespace variables for live tests - #20698

Merged
saragluna merged 5 commits into
Azure:masterfrom
moarychan:update/reduce-resource-creation-when-live-test
Apr 26, 2021
Merged

Should use the different storage account and eventhub namespace variables for live tests#20698
saragluna merged 5 commits into
Azure:masterfrom
moarychan:update/reduce-resource-creation-when-live-test

Conversation

@moarychan

@moarychan moarychan commented Apr 15, 2021

Copy link
Copy Markdown
Member

Follow this PR Upgrade Sinks api for eventhub/servicebus IT case's comments, improve live test configuration for reducing resource creation.

Conclusion:

  • We should use different eventhub namespaces and storage account for each IT class due to the different parameter 'baseName' value.
  • Use junit 5 classes.

@ghost ghost added the azure-spring All azure-spring related issues label Apr 15, 2021
@moarychan

Copy link
Copy Markdown
Member Author

@saragluna please help to commit the live test command, thanks.

@chenrujun

Copy link
Copy Markdown

/azp run java - spring - tests

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@chenrujun

Copy link
Copy Markdown

Please check the pipeline log, make sure related integration tests are executed.

I'm fixing the problem that pipeline passed but tests are not executed.
Refs: #20700

@backwind1233

Copy link
Copy Markdown
Contributor

/azp run java - spring - tests

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

…ate/reduce-resource-creation-when-live-test
@check-enforcer

Copy link
Copy Markdown

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run java - [service] - ci

@saragluna

Copy link
Copy Markdown
Member

/azp run java - spring - tests

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@backwind1233

Copy link
Copy Markdown
Contributor

/azp run java - spring - tests

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@moarychan moarychan changed the title Use the same storage account and eventhub namespace Should use the different storage account and eventhub namespace variables for live tests Apr 26, 2021
@saragluna saragluna self-assigned this Apr 26, 2021
@saragluna saragluna added the azure-spring-eventhubs Spring event hubs related issues. label Apr 26, 2021
@saragluna

Copy link
Copy Markdown
Member

/azp run java - spring - tests

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@saragluna saragluna left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@saragluna
saragluna merged commit de4ec2b into Azure:master Apr 26, 2021
@moarychan

Copy link
Copy Markdown
Member Author

Hi @saragluna , I found the guide about migration from Junit 4 and the other post of Junt 5 architecture introduce. Currently, the configuration will trigger all Junit test cases we used, after upgrade all the Junit 4 test cases, it's possible to remove the junit-vintage-engine and junit dependencies in each pom.xml file.

benbp pushed a commit that referenced this pull request Apr 28, 2021
…eventhub namespace variables for different modules (#20698)
@moarychan
moarychan deleted the update/reduce-resource-creation-when-live-test branch June 1, 2021 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

azure-spring All azure-spring related issues azure-spring-eventhubs Spring event hubs related issues.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants