Skip to content

Pass GPG Directory as Parameter to templates#23800

Merged
chidozieononiwu merged 2 commits into
Azure:mainfrom
chidozieononiwu:issue10196
Sep 4, 2021
Merged

Pass GPG Directory as Parameter to templates#23800
chidozieononiwu merged 2 commits into
Azure:mainfrom
chidozieononiwu:issue10196

Conversation

@chidozieononiwu

@chidozieononiwu chidozieononiwu commented Aug 27, 2021

Copy link
Copy Markdown
Member

@weshaggard weshaggard requested a review from hallipr August 31, 2021 20:54
Comment thread eng/pipelines/templates/stages/archetype-java-release.yml Outdated
Comment thread eng/pipelines/templates/steps/java-publishing.yml Outdated
Comment thread eng/pipelines/templates/stages/archetype-java-release.yml Outdated
@hallipr

hallipr commented Sep 2, 2021

Copy link
Copy Markdown
Member

Do we do anything else with $GPGToolDirectory other than set $GPGExecutablePath = $GPGToolDirectory\gpg.exe? Or, should we just replace $BuildToolsPath and its implicit $GPGExecutablePath with an explicit $GPGExecutablePath instead of replacing one implicit path with another?

Is it possible that someone won't have gpg.exe in $GPGToolDirectory and would prefer to use $GPGExecutablePath = 'some/path/to/gpg-1.2.3.beta.exe'?

@chidozieononiwu

Copy link
Copy Markdown
Member Author

Do we do anything else with $GPGToolDirectory other than set $GPGExecutablePath = $GPGToolDirectory\gpg.exe? Or, should we just replace $BuildToolsPath and its implicit $GPGExecutablePath with an explicit $GPGExecutablePath instead of replacing one implicit path with another?

Is it possible that someone won't have gpg.exe in $GPGToolDirectory and would prefer to use $GPGExecutablePath = 'some/path/to/gpg-1.2.3.beta.exe'?

I have updated that. Please also take a look at https://dev.azure.com/azure-sdk/internal/_git/azure-sdk-build-tools/pullrequest/200

@chidozieononiwu

Copy link
Copy Markdown
Member Author

/azp run java - core - ci

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@chidozieononiwu

Copy link
Copy Markdown
Member Author

/check-enforcer override

@chidozieononiwu

Copy link
Copy Markdown
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE REQ] Decouple knowledge gpg tooling location.

4 participants