Remove defunct parameters being passed to templates#41070
Merged
Conversation
weshaggard
approved these changes
Jul 9, 2024
Contributor
Author
|
The from source run ran too long and failed. At the time it was running there was a build storm triggered. That being said, that particular run has no bearing on these changes which are on the release task that was tested through the template pipeline release. I'm going to merge this without waiting for the one run to finish. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are minor changes to remove some defined variables and template parameters that were removed.
The BuildToolScripts variable reference, in the partner-release.yml, was removed with this PR but the variable wasn't.
The BuildTools path parameter for the java-publishing.yml was removed with this PR but never removed from things using the template.
Tested the changes running/releasing the template pipeline, for sanity, and everything released just fine.